further discountParser improvements

* the phonenumber package now handles checking if a line is a phone number
* removed the containsPhonePattern() and isNumericPhone() functions as they are no longer needed
* the extractEmail() function now uses regex to extract emails instead of for loops
* discountParser_test.go updated to remove tests that are no longer needed

Author: bvaic

parser/discountsParser.go

@@ -5,6 +5,7 @@ import (
 	"html"
 	"log"
 	"os"
+	"regexp"
 	"slices"
 	"strings"
 
@@ -135,10 +136,13 @@ func parseDiscountItem(s *goquery.Selection, category string) *schema.DiscountPr
 		}
 
 		// Check if it's a phone number
-		if containsPhonePattern(line) || isNumericPhone(line) {
-			// assumes that all phone numbers here are US phone numbers
-			discount.Phone = phonenumber.Parse(line, "US")
+		// phonenumber.Parse returns "" if not parsable as a phone number
+		// assumes that all phone numbers here are US phone numbers
+		parsed := phonenumber.Parse(line, "US")
+		if parsed != "" {
+			discount.Phone = parsed
 		}
+
 	}
 
 	var addresses = []string{}
@@ -191,17 +195,6 @@ func stripHTMLTags(s string) string {
 	return s
 }
 
-// isNumericPhone checks if a string is mostly numeric (like a phone number)
-func isNumericPhone(s string) bool {
-	digitCount := 0
-	for _, c := range s {
-		if c >= '0' && c <= '9' {
-			digitCount++
-		}
-	}
-	return digitCount >= 7 && len(s) <= 20
-}
-
 // isValidDiscount checks if a discount entry has meaningful data
 func isValidDiscount(d *schema.DiscountProgram) bool {
 	// Must have a business name
@@ -223,31 +216,18 @@ func isValidDiscount(d *schema.DiscountProgram) bool {
 	return hasContent
 }
 
-// containsPhonePattern checks if a string contains phone number patterns
-func containsPhonePattern(s string) bool {
-	// Simple check for phone number patterns like XXX-XXX-XXXX or (XXX) XXX-XXXX
-	return strings.Count(s, "-") >= 2 || (strings.Contains(s, "(") && strings.Contains(s, ")"))
-}
-
-// extractEmail extracts email from text
+// extractEmail uses regex to extract email addresses from text
 func extractEmail(text string) string {
-	text = strings.TrimSpace(text)
-
-	// Find @ symbol and extract email
-	if idx := strings.Index(text, "@"); idx != -1 {
-		// Find start and end of email
-		start := idx
-		for start > 0 && !strings.ContainsAny(string(text[start-1]), " \t\n\r,;") {
-			start--
-		}
-		end := idx
-		for end < len(text) && !strings.ContainsAny(string(text[end]), " \t\n\r,;") {
-			end++
-		}
-		return text[start:end]
+	const emailRegexPattern = `[a-zA-Z0-9._%+\-]+@[a-zA-Z0-9.\-]+\.[a-zA-Z]{2,4}`
+	var emailRegex = regexp.MustCompile(emailRegexPattern)
+
+	email := emailRegex.FindString(text)
+
+	if email == "" {
+		return "No email here"
 	}
 
-	return text
+	return email
 }
 
 // trimAfter returns the substring after the first occurrence of sep

parser/discountsParser_test.go

@@ -254,86 +254,6 @@ func TestCleanText(t *testing.T) {
 	}
 }
 
-// TestContainsPhonePattern tests phone number pattern detection
-func TestContainsPhonePattern(t *testing.T) {
-	t.Parallel()
-
-	testCases := map[string]struct {
-		input    string
-		expected bool
-	}{
-		"standard": {
-			input:    "972-214-5510",
-			expected: true,
-		},
-		"parentheses": {
-			input:    "(972) 214-5510",
-			expected: true,
-		},
-		"not_phone": {
-			input:    "Hello World",
-			expected: false,
-		},
-		"single_dash": {
-			input:    "Test-Name",
-			expected: false,
-		},
-	}
-
-	for name, tc := range testCases {
-		t.Run(name, func(t *testing.T) {
-			t.Parallel()
-
-			result := containsPhonePattern(tc.input)
-			if result != tc.expected {
-				t.Errorf("containsPhonePattern(%q) = %v, expected %v", tc.input, result, tc.expected)
-			}
-		})
-	}
-}
-
-// TestIsNumericPhone tests numeric phone detection
-func TestIsNumericPhone(t *testing.T) {
-	t.Parallel()
-
-	testCases := map[string]struct {
-		input    string
-		expected bool
-	}{
-		"numeric_phone": {
-			input:    "9722145510",
-			expected: true,
-		},
-		"with_spaces": {
-			input:    "972 214 5510",
-			expected: true,
-		},
-		"too_short": {
-			input:    "12345",
-			expected: false,
-		},
-		"too_long": {
-			input:    "123456789012345678901",
-			expected: false,
-		},
-		"not_numeric": {
-			input:    "Hello World",
-			expected: false,
-		},
-	}
-
-	for name, tc := range testCases {
-		t.Run(name, func(t *testing.T) {
-			t.Parallel()
-
-			result := isNumericPhone(tc.input)
-			if result != tc.expected {
-				t.Errorf("isNumericPhone(%q) = %v, expected %v", tc.input, result, tc.expected)
-			}
-		})
-	}
-}
-
 // TestExtractEmail tests email extraction from text
 func TestExtractEmail(t *testing.T) {
 	t.Parallel()