Skip to content

quality-debt: PR #792 review feedback (medium) #793

@superdav42

Description

@superdav42

Unactioned Review Feedback

Source PR: #792
File: general
Reviewers: coderabbit
Findings: 1
Max severity: medium


MEDIUM: coderabbit (coderabbitai[bot])

Verification: kept as unverifiable (no stable snippet extracted)
Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@inc/managers/class-membership-manager.php`:
- Around line 221-227: The code currently enqueues
wu_enqueue_async_action('wu_async_publish_pending_site', ...) and then returns
wp_send_json(['publish_status' => 'stopped']), creating two competing retry
sources; remove the Action Scheduler enqueue here so only the frontend retry
(publish_status => 'stopped') is relied on, or alternatively gate the enqueue
behind a check that ensures Membership::publish_pending_site() won't be retried
by both sources (e.g., consult the serialized is_publishing flag or a new marker
before calling wu_enqueue_async_action). Update the block containing
wu_enqueue_async_action and wp_send_json to either drop the enqueue call
entirely or add the guard so only a single retry path is used.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a5ea38a7-c5cc-4f3a-867e-f8dd2603c664

📥 Commits

Reviewing files that changed from the base of the PR and between a4bb4df and 3c07e3b.

📒 Files selected for processing (3)
  • inc/managers/class-membership-manager.php
  • inc/models/class-site.php
  • tests/WP_Ultimo/Models/Site_Test.php

View comment



Auto-generated by quality-feedback-helper.sh scan-merged. Review each finding and either fix the code or dismiss with a reason.


aidevops.sh v3.6.238 automated scan.

Metadata

Metadata

Assignees

Labels

origin:workerAuto-created by pulse labelless backfill (t2112)priority:mediumMedium severity — moderate quality issuequality-debtUnactioned review feedback from merged PRssource:review-feedbackAuto-created by quality-feedback-helper.shstatus:availableTask is available for claimingstatus:queuedWorker dispatched, not yet started

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions