Fix idle draw animation#504
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
beckermr
approved these changes
Jan 28, 2026
beckermr
reviewed
Jan 29, 2026
|
|
||
| [tool.pytest.ini_options] | ||
| filterwarnings = [ | ||
| "ignore:'resetCache' deprecated - use 'reset_cache':DeprecationWarning:matplotlib._fontconfig_pattern", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "ignore:'resetCache' deprecated - use 'reset_cache':DeprecationWarning:matplotlib._fontconfig_pattern", | |
| "ignore:'resetCache' deprecated - use 'reset_cache':DeprecationWarning:matplotlib._fontconfig_pattern", | |
| ] |
Collaborator
Author
There was a problem hiding this comment.
For some reason I cannot accept this change on the web but I don't see what this doesexactly given the code -- other than the extra lien
Collaborator
Author
|
This PR is not fixed yet. There are some funky things still happening on this PR. |
K-Mirembe-Mercy
pushed a commit
to K-Mirembe-Mercy/UltraPlot
that referenced
this pull request
Mar 22, 2026
* animation: skip auto_layout on draw_idle * layout: skip auto_layout unless layout is dirty * layout: avoid dirtying layout on backend size updates * ci: append coverage data with xdist * ci: force pytest-cov plugin with xdist * ci: fall back to full tests when selection is empty * ci: handle empty selected tests under bash -e * ci: fall back to full baseline generation on empty selection * ci: treat missing nodeids as empty selection * ci: run coverage without xdist to avoid worker gaps * ci: quiet pytest output * ci: suppress pytest warnings output * ci: stabilize pytest exit handling * ci: retry pytest without xdist on nonzero exit * ci: run main test step without xdist * ci: filter missing nodeids before pytest * ci: bump cache keys for test map and baselines * ci: rely on coverage step for test gating * ci: drop coverage step from build workflow * Remove workflow changes from branch * run test single thread * Prevent None from interfering with tickers * Remove git install * Harden workflow * update workflow * Restore workflow files * Apply suggestion from @beckermr --------- Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the animation draw pipeline to avoid repeated layout recomputation, which was causing layout jitter during animations. Auto‑layout now only runs when the layout is actually dirty or on the initial draw, and layout dirtiness is tracked across format calls, subplot/panel creation, and user‑driven size changes. Added a regression test to ensure draw_idle no longer retriggers layout. CI has been hardened: selected‑test mode now falls back to the full suite when nodeids are missing (exit code 4/5), baseline generation does the same on base commits, and coverage is collected in a single‑process pass to avoid xdist worker gaps. Finally, CI logs were made quieter with short tracebacks and warnings suppressed so failures are easier to spot.
Closes #488