fix: Swap computation order of condition in isStuck

misonijnik · misonijnik · commit d689a536a470 · 2024-11-29T15:41:43.000+01:00
diff --git a/lib/Core/ExecutionState.h b/lib/Core/ExecutionState.h
@@ -570,9 +570,9 @@ class ExecutionState {
   }
 
   inline bool isStuck(unsigned long long bound) const {
-    if (depth == 0)
+    if (depth == 0 || bound == 0)
       return false;
-    return isSymbolicCycled(bound) && klee::util::ulog2(depth) > bound;
+    return klee::util::ulog2(depth) > bound && isSymbolicCycled(bound);
   }
 
   bool isCoveredNew() const {

Original file line number	Diff line number	Diff line change
`@@ -570,9 +570,9 @@ class ExecutionState {`
`570`	`570`	`}`
`571`	`571`
`572`	`572`	`inline bool isStuck(unsigned long long bound) const {`
`573`		`- if (depth == 0)`
	`573`	`+ if (depth == 0 \|\| bound == 0)`
`574`	`574`	`return false;`
`575`		`- return isSymbolicCycled(bound) && klee::util::ulog2(depth) > bound;`
	`575`	`+ return klee::util::ulog2(depth) > bound && isSymbolicCycled(bound);`
`576`	`576`	`}`
`577`	`577`
`578`	`578`	`bool isCoveredNew() const {`