Stop querying isDeviceActive, start using Camera.stereoEnabled

XRSettings.isDeviceActive makes sense for general XR activity, but we should be using Camera.stereoEnabled for per camera stereo state.  I do cache this value in the PostProcessRenderContext.

Author: robbiesri

PostProcessing/Runtime/Effects/TemporalAntialiasing.cs

@@ -139,15 +139,7 @@ void GenerateHistoryName(RenderTexture rt, int id, PostProcessRenderContext cont
         {
             rt.name = "Temporal Anti-aliasing History id #" + id;
 
-            bool vrDeviceActive = false;
-
-#if UNITY_2017_2_OR_NEWER
-            vrDeviceActive = XR.XRSettings.isDeviceActive;
-#else
-            vrDeviceActive = VR.VRSettings.isDeviceActive;
-#endif
-
-            if (vrDeviceActive)
+            if (context.stereoActive)
                 rt.name += " for eye " + context.xrActiveEye;
         }
 

PostProcessing/Runtime/PostProcessLayer.cs

@@ -272,7 +272,7 @@ void OnPreCull()
             m_Camera.ResetProjectionMatrix();
             m_Camera.nonJitteredProjectionMatrix = m_Camera.projectionMatrix;
 
-            if (XRSettings.isDeviceActive)
+            if (m_Camera.stereoEnabled)
             {
                 m_Camera.ResetStereoProjectionMatrices();
                 Shader.SetGlobalFloat("rvsGlobal", XRSettings.renderViewportScale);
@@ -434,7 +434,7 @@ void OnPostRender()
             {
                 m_Camera.ResetProjectionMatrix();
 
-                if (XRSettings.isDeviceActive)
+                if (m_CurrentContext.stereoActive)
                 {
                     if (RuntimeUtilities.isSinglePassStereoEnabled || m_Camera.stereoActiveEye == Camera.MonoOrStereoscopicEye.Right)
                         m_Camera.ResetStereoProjectionMatrices();
@@ -618,7 +618,7 @@ public void Render(PostProcessRenderContext context)
             {
                 if (!RuntimeUtilities.scriptableRenderPipelineActive)
                 {
-                    if (XRSettings.isDeviceActive)
+                    if (context.stereoActive)
                     {
                         // We only need to configure all of this once for stereo, during OnPreCull
                         if (context.camera.stereoActiveEye != Camera.MonoOrStereoscopicEye.Right)

PostProcessing/Runtime/PostProcessRenderContext.cs

@@ -23,7 +23,7 @@ public Camera camera
             {
                 m_Camera = value;
 
-                if (XRSettings.isDeviceActive)
+                if (m_Camera.stereoEnabled)
                 {
 #if UNITY_2017_2_OR_NEWER
                     var xrDesc = XRSettings.eyeTextureDesc;
@@ -40,11 +40,12 @@ public Camera camera
                     height = XRSettings.eyeTextureHeight;
 #endif
 
-                    if (camera.stereoActiveEye == Camera.MonoOrStereoscopicEye.Right)
+                    if (m_Camera.stereoActiveEye == Camera.MonoOrStereoscopicEye.Right)
                         xrActiveEye = (int)Camera.StereoscopicEye.Right;
 
                     screenWidth = XRSettings.eyeTextureWidth;
                     screenHeight = XRSettings.eyeTextureHeight;
+                    stereoActive = true;
                 }
                 else
                 {
@@ -57,6 +58,7 @@ public Camera camera
 #endif
                     screenWidth = width;
                     screenHeight = height;
+                    stereoActive = false;
                 }
             }
         }
@@ -152,7 +154,8 @@ public void GetScreenSpaceTemporaryRT(CommandBuffer cmd, int nameID,
                 actualHeight = heightOverride;
 
             cmd.GetTemporaryRT(nameID, actualWidth, actualHeight, depthBufferBits, filter, colorFormat, readWrite);
-            // TODO: How to handle MSAA for XR in older versions?  Query cam?      
+            // TODO: How to handle MSAA for XR in older versions?  Query cam?
+            // TODO: Pass in vrUsage into the args 
 #endif
         }
 
@@ -179,6 +182,8 @@ public RenderTexture GetScreenSpaceTemporaryRT(int depthBufferBits = 0, RenderTe
 #endif
         }
 
+        public bool stereoActive { get; private set; }
+
         // Current active rendering eye (for XR)
         public int xrActiveEye { get; private set; }
 
@@ -207,6 +212,7 @@ public void Reset()
             m_sourceDescriptor = new RenderTextureDescriptor(0, 0);
 #endif
 
+            stereoActive = false;
             xrActiveEye = (int)Camera.StereoscopicEye.Left;
             screenWidth = 0;
             screenHeight = 0;