Refactor: Removes unnecessary imports and variables

Author: MiriamGaus

src/main/java/de/vill/conversion/ConvertAggregateFunction.java

@@ -56,7 +56,6 @@ private void searchAggregateFunctionInExpression(Expression expression) {
 
     private void replaceAggregateFunctionInExpression(Expression parentExpression, AggregateFunctionExpression aggregateFunctionExpression) {
         Feature rootFeature;
-        Expression aggregateFunctionReplacement;
         if (aggregateFunctionExpression.getRootFeature() == null) {
             rootFeature = rootFeatureModel.getRootFeature();
         } else {
@@ -74,7 +73,6 @@ private void replaceAggregateFunctionInExpression(Expression parentExpression, A
 
     private void replaceAggregateFunctionInExpressionConstraint(ExpressionConstraint parentExpression, AggregateFunctionExpression aggregateFunctionExpression) {
         Feature rootFeature;
-        Expression aggregateFunctionReplacement;
         if (aggregateFunctionExpression.getRootFeature() == null) {
             rootFeature = rootFeatureModel.getRootFeature();
         } else {
@@ -155,7 +153,6 @@ private void removeAggregateFunctionFromAttributes(Feature feature) {
             }
         }
         if (attributeConstraintList != null && attributeConstraintList.getValue() instanceof List<?>) {
-            List<Object> newConstraintList = new LinkedList<>();
             for (Object constraint : (List<?>) attributeConstraintList.getValue()) {
                 if (constraint instanceof Constraint) {
                     searchAggregateFunctionInConstraint((Constraint) constraint);

src/main/java/de/vill/conversion/ConvertSMTLevel.java

@@ -3,8 +3,6 @@
 import com.google.common.collect.Sets;
 import de.vill.model.*;
 import de.vill.model.constraint.*;
-import de.vill.model.expression.AggregateFunctionExpression;
-import de.vill.model.expression.BinaryExpression;
 import de.vill.model.expression.Expression;
 import de.vill.model.expression.LiteralExpression;
 

src/main/java/de/vill/conversion/ConvertStringConstraints.java

@@ -8,7 +8,6 @@
 import de.vill.model.constraint.Constraint;
 import de.vill.model.constraint.EqualEquationConstraint;
 import de.vill.model.constraint.ExpressionConstraint;
-import de.vill.model.expression.AggregateFunctionExpression;
 import de.vill.model.expression.Expression;
 import de.vill.model.expression.LengthAggregateFunctionExpression;
 import de.vill.model.expression.LiteralExpression;
@@ -23,7 +22,6 @@
 
 public class ConvertStringConstraints implements IConversionStrategy {
     private final Map<String, Map<String, Attribute<?>>> featuresToBeUpdated = new HashMap<>();
-    private FeatureModel rootFeatureModel;
 
     @Override
     public Set<LanguageLevel> getLevelsToBeRemoved() {
@@ -35,9 +33,10 @@ public Set<LanguageLevel> getTargetLevelsOfConversion() {
         return new HashSet<>(Collections.singletonList(LanguageLevel.TYPE_LEVEL));
     }
 
+
+    // TODO is not matching with the Interface definition, should be fixed
     @Override
     public void convertFeatureModel(final FeatureModel rootFeatureModel, final FeatureModel featureModel) {
-        this.rootFeatureModel = rootFeatureModel;
         rootFeatureModel.getOwnConstraints().forEach(this::convertStringAggregateFunctionInExpressionConstraint);
         rootFeatureModel.getOwnConstraints().removeIf(x -> containsStringEqualityExpression(x));
         this.traverseFeatures(rootFeatureModel.getRootFeature());

src/main/java/de/vill/conversion/ConvertTypeLevel.java

@@ -16,7 +16,7 @@
 import java.util.Set;
 
 public class ConvertTypeLevel implements IConversionStrategy {
-    FeatureModel rootFeatureModel;
+    private FeatureModel rootFeatureModel;
 
     @Override
     public Set<LanguageLevel> getLevelsToBeRemoved() {

src/main/java/de/vill/conversion/IConversionStrategy.java

@@ -10,6 +10,17 @@ public interface IConversionStrategy {
 
     Set<LanguageLevel> getTargetLevelsOfConversion();
 
+    /**
+     * Converts the given feature model according to the implemented strategy.
+     * <p>
+     * The {@code rootFeatureModel} provides the context of the entire feature model,
+     * while {@code featureModel} is the (sub-)model that will be modified during the conversion.
+     * <p>
+     * Typically, only {@code featureModel} is changed; {@code rootFeatureModel} is used for reference.
+     * If the entire model should be converted, both parameters can reference the same instance.
+     *
+     * @param rootFeatureModel the root or complete feature model, used as context/reference (not modified)
+     * @param featureModel the feature model (or submodel) to be converted (will be modified)
+     */
     void convertFeatureModel(FeatureModel rootFeatureModel, FeatureModel featureModel);
-
 }