Skip to content

Commit f45e908

Browse files
committed
Debug bugfix + tests
- Added some type casting
1 parent 793ac33 commit f45e908

7 files changed

Lines changed: 16 additions & 4 deletions

File tree

src/Client/Cache/MySQL/Manager.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public function debug($base)
7272
);
7373
$query->bindParam(':base', $base, PDO::PARAM_STR);
7474
$query->execute();
75-
return $query->fetchAll(PDO::FETCH_ASSOC);
75+
return $query->rowCount() > 0 ? $query->fetch(PDO::FETCH_ASSOC) : [];
7676
}
7777

7878
/**

src/Client/Delay/MySQL/Manager.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,6 @@ public function debug($base)
100100
);
101101
$query->bindParam(':base', $base, PDO::PARAM_STR);
102102
$query->execute();
103-
return $query->fetchAll(PDO::FETCH_ASSOC);
103+
return $query->rowCount() > 0 ? $query->fetch(PDO::FETCH_ASSOC) : [];
104104
}
105105
}

src/Parser/Directives/RequestRateParser.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ public function client($userAgent = self::USER_AGENT, $fallbackValue = 0)
120120
*/
121121
private function sort()
122122
{
123-
usort($this->requestRates, function ($requestRateA, $requestRateB) {
123+
usort($this->requestRates, function (array $requestRateA, array $requestRateB) {
124124
// PHP 7: Switch to the <=> "Spaceship" operator
125125
return $requestRateB['rate'] > $requestRateA['rate'];
126126
});

src/Parser/Directives/VisitTimeParser.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public function render(RenderHandler $handler)
8282
*/
8383
private function sort()
8484
{
85-
usort($this->visitTimes, function ($visitTimeA, $visitTimeB) {
85+
usort($this->visitTimes, function (array $visitTimeA, array $visitTimeB) {
8686
// PHP 7: Switch to the <=> "Spaceship" operator
8787
return $visitTimeA['from'] > $visitTimeB['from'];
8888
});

tests/CacheSQLTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@ public function testCacheSQL($uri, $base)
5353
$parser->client($uri);
5454
}
5555

56+
$this->assertTrue(count($parser->debug($uri), COUNT_NORMAL) >= 5);
57+
5658
$parser->cron();
5759
$parser->clean();
5860

tests/DelaySQLTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ public function testDelaySQL($uri, $userAgent)
6262
$queue = $client->getQueue();
6363
$this->assertLessThanOrEqual(60, $queue);
6464
$this->assertGreaterThan(59, $queue);
65+
$this->assertTrue(count($delayHandler->debug($uri), COUNT_NORMAL) >= 3);
6566
}
6667

6768
$client->reset();

tests/ExportTest.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -340,4 +340,13 @@ public function generateDataForTest()
340340
]
341341
];
342342
}
343+
344+
public function testRenderInvalidNewLine()
345+
{
346+
$parser = new RobotsTxtParser\TxtClient('http://example.com', 200, '');
347+
$this->assertInstanceOf('vipnytt\RobotsTxtParser\TxtClient', $parser);
348+
349+
$this->expectException(RobotsTxtParser\Exceptions\ClientException::class);
350+
$parser->render()->normal('<br>');
351+
}
343352
}

0 commit comments

Comments
 (0)