Made it actually work

Replaces `sceneName` with `scenePrefix` for better clarity and flexibility in player scene naming. Moves player recording list handling to `LoopSceneManager`, including serialization and deserialization. Simplifies and enhances the loop playback and scene configuration logic.

Author: VLTNOgithub

src/main/java/com/vltno/timeloop/Commands.java

@@ -240,8 +240,11 @@ public void register(CommandDispatcher<ServerCommandSource> dispatcher, CommandR
                             mod.config.displayTimeInTicks = false;
 
                             mod.executeCommand("mocap playback stop_all");
-                            mod.executeCommand(String.format("mocap scenes remove %s", mod.sceneName));
-                            mod.executeCommand(String.format("mocap scenes add %s", mod.sceneName));
+                            mod.loopSceneManager.forEachPlayerSceneName(playerSceneName -> {
+                                mod.executeCommand(String.format("mocap scenes remove %s", playerSceneName));
+                                mod.executeCommand(String.format("mocap scenes add %s", playerSceneName));
+                            });
+
                             mod.loopIteration = 0;
                             mod.config.loopIteration = 0;
                             mod.config.save();

src/main/java/com/vltno/timeloop/LoopSceneManager.java

@@ -6,20 +6,20 @@
 
 public class LoopSceneManager {
     private TimeLoopConfig config;
-    private String sceneName;
+    private String scenePrefix;
     private List<String> recordingPlayers;
 
     // Constructor to initialize recordingPlayers
-    public LoopSceneManager(TimeLoopConfig _config) {
-        this.config = _config;
-        this.sceneName = config.sceneName;
+    public LoopSceneManager(TimeLoopConfig config) {
+        this.config = config;
+        this.scenePrefix = config.scenePrefix;
         this.recordingPlayers = new ArrayList<>();
     }
 
     // Method to add a player to the recordingPlayers list
     public void addPlayer(String playerName) {
         if (playerName != null && !playerName.isEmpty()) {
-            recordingPlayers.add(playerName.toLowerCase());
+            recordingPlayers.add(playerName);
         } else {
             System.out.println("Invalid player name. Player not added.");
         }
@@ -41,7 +41,7 @@ public void removePlayer(String playerName) {
 
     // Method to generate playerSceneName for a given player
     public String getPlayerSceneName(String playerName) {
-        return (sceneName + "_" + playerName).toLowerCase();
+        return (playerName.startsWith(scenePrefix)) ? playerName : (scenePrefix + "_" + playerName).toLowerCase();
     }
 
     // Method to get all playerSceneNames for recordingPlayers
@@ -60,4 +60,12 @@ public void forEachPlayerSceneName(Consumer<String> action) {
     public void forEachRecordingPlayer(Consumer<String> action) {
         recordingPlayers.forEach(action);
     }
+    
+    public void setRecordingPlayers(List<String> recordingPlayers) {
+        this.recordingPlayers = recordingPlayers;
+    }
+    
+    public void saveRecordingPlayers() {
+        config.recordingPlayers = this.recordingPlayers;
+    }
 }

src/main/java/com/vltno/timeloop/TimeLoop.java

@@ -43,7 +43,6 @@ public class TimeLoop implements ModInitializer {
 	public boolean trackTimeOfDay;
 	public boolean isLooping;
 	public int maxLoops;
-	public String sceneName;
 	private int tickCounter = 0; // Tracks elapsed ticks
 	public int ticksLeft;
 
@@ -56,7 +55,7 @@ public class TimeLoop implements ModInitializer {
 	public TimeLoopConfig config;
 
 	// The loop scene manager object
-	private LoopSceneManager loopSceneManager;
+	public LoopSceneManager loopSceneManager;
 
 	// Get the world folder path for config/recording loading
 	private Path worldFolder;
@@ -65,7 +64,6 @@ public class TimeLoop implements ModInitializer {
 	@Override
 	public void onInitialize() {
 		LOOP_LOGGER.info("Initializing TimeLoop mod");
-		loopSceneManager = new LoopSceneManager(config);
 
 		// Register the custom ArgumentType
 		ArgumentTypeRegistry.registerArgumentType(Identifier.of("timeloop",""), LoopTypesArgumentType.class, ConstantArgumentSerializer.of(LoopTypesArgumentType::new));
@@ -92,20 +90,24 @@ public void onInitialize() {
 			worldFolder = server.getSavePath(WorldSavePath.ROOT);
 			config = TimeLoopConfig.load(worldFolder);
 
+			// Loop scene manager
+			loopSceneManager = new LoopSceneManager(config);
+
 			loopIteration = config.loopIteration;
 			loopLengthTicks = config.loopLengthTicks;
 			isLooping = config.isLooping;
 			startTimeOfDay = config.startTimeOfDay;
 			timeSetting = config.timeSetting;
 			trackTimeOfDay = config.trackTimeOfDay;
 			ticksLeft = config.ticksLeft;
-			sceneName = config.sceneName;
 
 			showLoopInfo = config.showLoopInfo;
 			displayTimeInTicks = config.displayTimeInTicks;
 			trackItems = config.trackItems;
 			loopType = config.loopType;
 
+			loopSceneManager.setRecordingPlayers(config.recordingPlayers);
+			
 			TimeLoop.server = server;
 			serverWorld = server.getOverworld();
 
@@ -121,6 +123,14 @@ public void onInitialize() {
 			executeCommand("mocap settings recording entity_tracking_distance 1");
 
 			updateEntitiesToTrack(trackItems);
+			
+			try {
+				loopSceneManager.forEachPlayerSceneName(playerSceneName -> {
+					executeCommand(String.format("mocap scenes add %s", playerSceneName));
+				});
+			} catch (Error e) {
+				LOOP_LOGGER.error("Failed to add player scenes to mocap scenes: {}", e.getMessage());
+			}
 		});
 
 		ServerLifecycleEvents.SERVER_STOPPING.register(server -> {
@@ -164,6 +174,7 @@ public void onInitialize() {
 			loopBossBar.removePlayer(player);
 			if (isLooping) {
 				saveRecordings();
+				loopSceneManager.saveRecordingPlayers();
 			}
 		});
 
@@ -216,7 +227,7 @@ public void startLoop() {
 			LOOP_LOGGER.info("Attempted to start already running recording loop");
 			return;
 		}
-        if (showLoopInfo) {loopBossBar.visible(true);}
+        if (showLoopInfo) { loopBossBar.visible(true); }
 		isLooping = true;
 		config.isLooping = true;
 		tickCounter = 0;
@@ -237,7 +248,7 @@ private void runLoopIteration() {
 		executeCommand("mocap playback stop_all including_others");
 
 		loopSceneManager.forEachPlayerSceneName(playerSceneName -> {
-			executeCommand(String.format("mocap playback start .%s", loopSceneManager.getPlayerSceneName(playerSceneName)));
+			executeCommand(String.format("mocap playback start .%s", playerSceneName));
 		});
 
 		loopIteration++;
@@ -285,6 +296,7 @@ public void stopLoop() {
 			config.isLooping = false;
 			loopBossBar.visible(false);
 			saveRecordings();
+			loopSceneManager.saveRecordingPlayers();
 			executeCommand("mocap playback stop_all including_others");
 			tickCounter = 0;
 			ticksLeft = loopLengthTicks;

src/main/java/com/vltno/timeloop/TimeLoopConfig.java

@@ -8,10 +8,12 @@
 import java.io.Writer;
 import java.nio.file.Files;
 import java.nio.file.Path;
+import java.util.ArrayList;
+import java.util.List;
 
 public class TimeLoopConfig {
     // These values will be loaded/saved from/to the JSON config file.bossbar set minecraft:loop_info
-    public String sceneName = "loop_scene";
+    public String scenePrefix = "loop_scene";
     public boolean firstStart = true;
     public int loopIteration = 1;
     public boolean isLooping = false;
@@ -26,6 +28,8 @@ public class TimeLoopConfig {
     public boolean displayTimeInTicks = false;
     public boolean trackItems = false;
     public LoopTypes loopType = LoopTypes.TICKS;
+    
+    public List<String> recordingPlayers = new ArrayList<>();
 
     private static final Gson GSON = new GsonBuilder().setPrettyPrinting().create();
     private static Path configPath;
@@ -49,6 +53,7 @@ public static TimeLoopConfig load(Path configDir) {
         }
         // Create default config if none exists
         TimeLoopConfig config = new TimeLoopConfig();
+//        config.recordingPlayers.add("stufffffffffffff");
         config.save();
         return config;
     }