Skip to content

Commit bb757c2

Browse files
update gradle
1 parent 59c04fc commit bb757c2

6 files changed

Lines changed: 51 additions & 16 deletions

File tree

app/build.properties

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#Build Properties
2-
#Sat Jan 18 09:56:30 EST 2025
3-
version_build=2
2+
#Sun Feb 23 13:34:01 EST 2025
3+
version_build=3
44
version_major=3
55
version_minor=1
66
version_patch=4

app/jacoco.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,15 +66,15 @@ task jacocoTestCoverageVerification(type: JacocoCoverageVerification, dependsOn:
6666
element = 'BUNDLE'
6767
limit {
6868
counter = 'INSTRUCTION'
69-
minimum = 0.96
69+
minimum = 0.97
7070
}
7171
limit {
7272
counter = 'BRANCH'
73-
minimum = 0.84
73+
minimum = 0.88
7474
}
7575
limit {
7676
counter = 'COMPLEXITY'
77-
minimum = 0.89
77+
minimum = 0.92
7878
}
7979
limit {
8080
counter = 'LINE'

app/src/main/AndroidManifest.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,4 @@
5656
</intent-filter>
5757
</activity>
5858
</application>
59-
60-
<queries>
61-
<package android:name="com.aaronjwood.portauthority" />
62-
<package android:name="com.aaronjwood.portauthority.free" />
63-
<package android:name="com.aaronjwood.portauthority.donate" />
64-
</queries>
6559
</manifest>

app/src/main/kotlin/com/vrem/wifianalyzer/MainActivity.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,10 +100,10 @@ class MainActivity : AppCompatActivity(), NavigationMenuControl, OnSharedPrefere
100100
}
101101

102102
override fun onRequestPermissionsResult(requestCode: Int, permissions: Array<String>, grantResults: IntArray) {
103+
super.onRequestPermissionsResult(requestCode, permissions, grantResults)
103104
if (!MainContext.INSTANCE.permissionService.granted(requestCode, grantResults)) {
104105
finish()
105106
}
106-
super.onRequestPermissionsResult(requestCode, permissions, grantResults)
107107
}
108108

109109
private fun setWiFiChannelPairs(mainContext: MainContext) {
@@ -181,16 +181,21 @@ class MainActivity : AppCompatActivity(), NavigationMenuControl, OnSharedPrefere
181181

182182
public override fun onStop() {
183183
MainContext.INSTANCE.scannerService.stop()
184+
updateActionBar()
184185
super.onStop()
185186
}
186187

187188
public override fun onStart() {
188189
super.onStart()
189190
if (MainContext.INSTANCE.permissionService.permissionGranted()) {
191+
if (!MainContext.INSTANCE.permissionService.locationEnabled()) {
192+
startLocationSettings()
193+
}
190194
MainContext.INSTANCE.scannerService.resume()
191195
} else {
192196
MainContext.INSTANCE.permissionService.check()
193197
}
198+
updateActionBar()
194199
}
195200

196201
override fun onCreateOptionsMenu(menu: Menu): Boolean {

app/src/test/kotlin/com/vrem/wifianalyzer/MainActivityTest.kt

Lines changed: 38 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ import org.junit.After
3232
import org.junit.Test
3333
import org.junit.runner.RunWith
3434
import org.mockito.kotlin.mock
35+
import org.mockito.kotlin.never
3536
import org.mockito.kotlin.verify
3637
import org.mockito.kotlin.whenever
3738
import org.robolectric.Robolectric
@@ -64,7 +65,7 @@ class MainActivityTest {
6465
}
6566

6667
@Test
67-
fun onResumeWithPermissionGrantedWillResumeScanner() {
68+
fun onResumeWithPermissionGrantedAndLocationDisabledWillResumeScanner() {
6869
// setup
6970
val permissionService = MainContextHelper.INSTANCE.permissionService
7071
val scannerService = MainContextHelper.INSTANCE.scannerService
@@ -79,6 +80,22 @@ class MainActivityTest {
7980
verify(scannerService).register(fixture.connectionView)
8081
}
8182

83+
@Test
84+
fun onResumeWithPermissionGrantedAndLocationEnabledWillResumeScanner() {
85+
// setup
86+
val permissionService = MainContextHelper.INSTANCE.permissionService
87+
val scannerService = MainContextHelper.INSTANCE.scannerService
88+
whenever(permissionService.permissionGranted()).thenReturn(true)
89+
whenever(permissionService.locationEnabled()).thenReturn(true)
90+
// execute
91+
fixture.onResume()
92+
// validate
93+
verify(permissionService).permissionGranted()
94+
verify(permissionService).locationEnabled()
95+
verify(scannerService).resume()
96+
verify(scannerService).register(fixture.connectionView)
97+
}
98+
8299
@Test
83100
fun onResumeWithPermissionNotGrantedWillPauseScanner() {
84101
// setup
@@ -91,19 +108,37 @@ class MainActivityTest {
91108
verify(scannerService).pause()
92109
verify(scannerService).register(fixture.connectionView)
93110
verify(permissionService).permissionGranted()
111+
verify(permissionService, never()).locationEnabled()
94112
}
95113

96114
@Test
97-
fun onStartWithPermissionGrantedWillResumeScanner() {
115+
fun onStartWithPermissionGrantedAndLocationDisabledWillResumeScanner() {
98116
// setup
99117
val permissionService = MainContextHelper.INSTANCE.permissionService
100118
val scannerService = MainContextHelper.INSTANCE.scannerService
101119
whenever(permissionService.permissionGranted()).thenReturn(true)
120+
whenever(permissionService.locationEnabled()).thenReturn(false)
102121
// execute
103122
fixture.onStart()
104123
// validate
105124
verify(scannerService).resume()
106125
verify(permissionService).permissionGranted()
126+
verify(permissionService).locationEnabled()
127+
}
128+
129+
@Test
130+
fun onStartWithPermissionGrantedAndLocationEnabledWillResumeScanner() {
131+
// setup
132+
val permissionService = MainContextHelper.INSTANCE.permissionService
133+
val scannerService = MainContextHelper.INSTANCE.scannerService
134+
whenever(permissionService.permissionGranted()).thenReturn(true)
135+
whenever(permissionService.locationEnabled()).thenReturn(true)
136+
// execute
137+
fixture.onStart()
138+
// validate
139+
verify(scannerService).resume()
140+
verify(permissionService).permissionGranted()
141+
verify(permissionService).locationEnabled()
107142
}
108143

109144
@Test
@@ -116,6 +151,7 @@ class MainActivityTest {
116151
// validate
117152
verify(permissionService).check()
118153
verify(permissionService).permissionGranted()
154+
verify(permissionService, never()).locationEnabled()
119155
}
120156

121157
@Test

build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,14 @@
2020

2121
buildscript {
2222
ext {
23-
kotlin_version = '2.1.0'
23+
kotlin_version = '2.1.10'
2424
}
2525
repositories {
2626
google()
2727
mavenCentral()
2828
}
2929
dependencies {
30-
classpath 'com.android.tools.build:gradle:8.8.0'
30+
classpath 'com.android.tools.build:gradle:8.8.1'
3131
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
3232
classpath "org.jetbrains.kotlin:kotlin-allopen:$kotlin_version"
3333
}

0 commit comments

Comments
 (0)