GNU3 demangler: remove dead code and unused function

- Remove unreachable C1-C5/D0-D5 cases from GetNameType() — these
  are handled directly by DemangleUnqualifiedName's own case blocks
- Remove unused DemangleInitializer() (declaration and definition)
- Remove dead "." operator check in DemangleBinaryExpression — the
  dt (member access) operator has its own handler in DemangleExpression

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: plafosse

demangler/gnu3/demangle_gnu3.cpp

@@ -209,17 +209,9 @@ static BNNameType GetNameType(char elm1, char elm2)
 	case hash('d','a'): return OperatorDeleteArrayNameType;     // delete[]
 	case hash('n','w'): return OperatorNewNameType;             // new
 	case hash('n','a'): return OperatorNewArrayNameType;        // new []
-	case hash('C','1'): return ConstructorNameType;
-	case hash('C','2'): return ConstructorNameType;
-	case hash('C','3'): return ConstructorNameType;
-	case hash('C','4'): return ConstructorNameType;
-	case hash('C','5'): return ConstructorNameType;
-	case hash('D','0'): return DestructorNameType;
-	case hash('D','1'): return DestructorNameType;
-	case hash('D','2'): return DestructorNameType;
-	case hash('D','3'): return DestructorNameType;
-	case hash('D','4'): return DestructorNameType;
-	case hash('D','5'): return DestructorNameType;
+	// Note: C1-C5 (constructor) and D0-D5 (destructor) are handled directly
+	// by DemangleUnqualifiedName with their own case blocks, so they never
+	// reach GetNameType.
 	default:
 		return NoNameType;
 	}
@@ -992,20 +984,6 @@ int64_t DemangleGNU3::DemangleNumber()
 }
 
 
-string DemangleGNU3::DemangleInitializer()
-{
-	string out;
-	if (m_reader.ReadString(2) != "pi")
-		throw DemangleException();
-	out += "(";
-	while (m_reader.Peek() != 'E')
-		out += DemangleExpression();
-	m_reader.Consume();
-	out += ")";
-	return out;
-}
-
-
 string DemangleGNU3::DemanglePrimaryExpression()
 {
 	indent();
@@ -1139,8 +1117,6 @@ string DemangleGNU3::DemangleBinaryExpression(const string& op)
 	const string lhs = "(" + DemangleExpression() + ")";
 	const string rhs = "(" + DemangleExpression() + ")";
 	dedent();
-	if (op == ".")
-		return lhs + op + rhs;
 	return lhs + " " + op + " " + rhs;
 }
 

demangler/gnu3/demangle_gnu3.h

@@ -133,7 +133,6 @@ class DemangleGNU3
 	DemangledTypeNode DemangleUnqualifiedName();
 	_STD_STRING DemangleSourceName();
 	_STD_STRING DemangleNumberAsString();
-	_STD_STRING DemangleInitializer();
 	_STD_STRING DemangleExpression();
 	_STD_STRING DemanglePrimaryExpression();
 	DemangledTypeNode DemangleName();