Skip to content

Commit ef004cf

Browse files
committed
Fix blocks_attack backup with null bypass tag
Closes #1228
1 parent 4f4fd5d commit ef004cf

2 files changed

Lines changed: 5 additions & 18 deletions

File tree

common/src/main/java/com/viaversion/viabackwards/protocol/v1_21_5to1_21_4/rewriter/BlockItemPacketRewriter1_21_5.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,10 @@ protected void restoreBackupData(final Item item, final StructuredDataContainer
541541
damageReductions.add(new DamageReduction(horizontalBlockingAngle, type, base, factor));
542542
}
543543

544-
data.set(StructuredDataKey.BLOCKS_ATTACKS1_21_5, new BlocksAttacks(blockDelaySeconds, disableCooldownScale, damageReductions.toArray(new DamageReduction[0]), itemDamage, HolderSet.of(bypassedBy), blockSound, disableSound));
544+
data.set(StructuredDataKey.BLOCKS_ATTACKS1_21_5, new BlocksAttacks(
545+
blockDelaySeconds, disableCooldownScale, damageReductions.toArray(new DamageReduction[0]),
546+
itemDamage, bypassedBy != null ? HolderSet.of(bypassedBy) : null, blockSound, disableSound
547+
));
545548
}
546549

547550
final IntTag chickenVariant = backupTag.getIntTag("chicken_variant");

common/src/main/java/com/viaversion/viabackwards/protocol/v26_1to1_21_11/rewriter/BlockItemPacketRewriter26_1.java

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import com.viaversion.viaversion.api.minecraft.data.StructuredDataContainer;
2626
import com.viaversion.viaversion.api.minecraft.data.StructuredDataKey;
2727
import com.viaversion.viaversion.api.minecraft.item.Item;
28-
import com.viaversion.viaversion.api.protocol.packet.PacketWrapper;
2928
import com.viaversion.viaversion.api.type.types.chunk.ChunkType1_21_5;
3029
import com.viaversion.viaversion.api.type.types.chunk.ChunkType26_1;
3130
import com.viaversion.viaversion.protocols.v1_21_11to26_1.packet.ClientboundPacket26_1;
@@ -73,22 +72,7 @@ public void registerPackets() {
7372
registerShowDialog(ClientboundPackets26_1.SHOW_DIALOG);
7473
registerShowDialogDirect(ClientboundConfigurationPackets1_21_9.SHOW_DIALOG);
7574

76-
final RecipeDisplayRewriter<ClientboundPacket26_1> recipeRewriter = new RecipeDisplayRewriter1_21_5<>(protocol) {
77-
@Override
78-
protected void handleDyeSlotDisplay(final PacketWrapper wrapper) {
79-
wrapper.consumeReadsOnly(() -> super.handleDyeSlotDisplay(wrapper));
80-
}
81-
82-
@Override
83-
protected void handleOnlyWithComponentSlotDisplay(final PacketWrapper wrapper) {
84-
wrapper.consumeReadsOnly(() -> super.handleOnlyWithComponentSlotDisplay(wrapper));
85-
}
86-
87-
@Override
88-
protected void handleWithRemainderSlotDisplay(final PacketWrapper wrapper) {
89-
wrapper.consumeReadsOnly(() -> super.handleWithRemainderSlotDisplay(wrapper));
90-
}
91-
};
75+
final RecipeDisplayRewriter<ClientboundPacket26_1> recipeRewriter = new RecipeDisplayRewriter1_21_5<>(protocol);
9276
recipeRewriter.registerUpdateRecipes(ClientboundPackets26_1.UPDATE_RECIPES);
9377
recipeRewriter.registerRecipeBookAdd(ClientboundPackets26_1.RECIPE_BOOK_ADD);
9478
recipeRewriter.registerPlaceGhostRecipe(ClientboundPackets26_1.PLACE_GHOST_RECIPE);

0 commit comments

Comments
 (0)