Skip to content

Commit 351fc89

Browse files
committed
address rails warning differently
1 parent ecb9533 commit 351fc89

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ jobs:
4848
bundler-cache: true
4949
- name: Build and test with Rake
5050
run: |
51-
bundle exec appraisal rails-${{ matrix.rails_version }} bundle
51+
bundle exec appraisal rails-${{ matrix.rails_version }} bundle --ignore_funding_requests
5252
MEASURE_COVERAGE=true bundle exec appraisal rails-${{ matrix.rails_version }} rake
5353
env:
5454
RAISE_ON_WARNING: 1
@@ -89,7 +89,7 @@ jobs:
8989
cd primer_view_components
9090
npm ci
9191
cd demo && npm ci && cd ..
92-
bundle && bundle exec rake
92+
bundle --ignore_funding_requests && bundle exec rake
9393
env:
9494
VIEW_COMPONENT_PATH: ../view_component
9595
RAILS_VERSION: '7.1.5'

test/sandbox/config/application.rb

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,9 @@
3737

3838
module Sandbox
3939
class Application < Rails::Application
40-
config.action_controller.asset_host = "http://assets.example.com"
40+
config.load_defaults(8.1) if Rails::VERSION::MAJOR == 8 && Rails::VERSION::MINOR == 1
4141

42-
if config.action_controller.respond_to?(:escape_json_responses=)
43-
config.action_controller.escape_json_responses = false
44-
end
42+
config.action_controller.asset_host = "http://assets.example.com"
4543

4644
# Prepare test_set_no_duplicate_autoload_paths
4745
config.autoload_paths.push("#{config.root}/my/components/previews")

0 commit comments

Comments
 (0)