fix panic on in list expansion with a subselect

Author: mrj0

bind.go

@@ -212,8 +212,9 @@ func In(query string, args ...interface{}) (string, []interface{}, error) {
 			argMeta := meta[arg]
 			arg++
 
-			// not an in-list
-			if !inIn {
+			if !inIn || !argMeta.v.IsValid() {
+				// this QuestionMark is not in an in-list that needs expansion.
+				// if v is invalid, then the arg isn't a slice
 				newArgs = append(newArgs, argMeta.i)
 				buf.WriteString(token.Text)
 				continue

bind_test.go

@@ -3,6 +3,10 @@ package sqlx
 import (
 	"math/rand"
 	"testing"
+	"time"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 func oldBindType(driverName string) int {
@@ -77,3 +81,14 @@ func BenchmarkBindSpeed(b *testing.B) {
 
 	})
 }
+
+func TestInNotSlice(t *testing.T) {
+	now := time.Now()
+	args := []any{[]string{"a", "b"}, now}
+	query := ` SELECT * FROM person WHERE first_name IN (?) AND id IN ( SELECT id FROM something WHERE created_at = ? )`
+	insql, newArgs, err := In(query, args...)
+	require.NoError(t, err)
+	assert.Contains(t, insql, "IN (?, ?)")
+	assert.Contains(t, insql, "WHERE created_at = ? )")
+	assert.Equal(t, []any{"a", "b", now}, newArgs)
+}