Merge pull request #5 from Vinovest/mj/cleanup-skipped-test

remove skipped tests

Author: mrj0

sqlx_context_test.go

@@ -12,7 +12,6 @@ package sqlx
 import (
 	"context"
 	"database/sql"
-	"encoding/json"
 	"fmt"
 	"log"
 	"strings"
@@ -1164,47 +1163,6 @@ func TestEmbeddedMapsContext(t *testing.T) {
 	})
 }
 
-func TestIssue197Context(t *testing.T) {
-	// this test actually tests for a bug in database/sql:
-	//   https://github.com/golang/go/issues/13905
-	// this potentially makes _any_ named type that is an alias for []byte
-	// unsafe to use in a lot of different ways (basically, unsafe to hold
-	// onto after loading from the database).
-	t.Skip()
-
-	type mybyte []byte
-	type Var struct{ Raw json.RawMessage }
-	type Var2 struct{ Raw []byte }
-	type Var3 struct{ Raw mybyte }
-	RunWithSchemaContext(context.Background(), defaultSchema, t, func(ctx context.Context, db *DB, t *testing.T) {
-		var err error
-		var v, q Var
-		if err = db.GetContext(ctx, &v, `SELECT '{"a": "b"}' AS raw`); err != nil {
-			t.Fatal(err)
-		}
-		if err = db.GetContext(ctx, &q, `SELECT 'null' AS raw`); err != nil {
-			t.Fatal(err)
-		}
-
-		var v2, q2 Var2
-		if err = db.GetContext(ctx, &v2, `SELECT '{"a": "b"}' AS raw`); err != nil {
-			t.Fatal(err)
-		}
-		if err = db.GetContext(ctx, &q2, `SELECT 'null' AS raw`); err != nil {
-			t.Fatal(err)
-		}
-
-		var v3, q3 Var3
-		if err = db.QueryRowContext(ctx, `SELECT '{"a": "b"}' AS raw`).Scan(&v3.Raw); err != nil {
-			t.Fatal(err)
-		}
-		if err = db.QueryRowContext(ctx, `SELECT '{"c": "d"}' AS raw`).Scan(&q3.Raw); err != nil {
-			t.Fatal(err)
-		}
-		t.Fail()
-	})
-}
-
 func TestInContext(t *testing.T) {
 	// some quite normal situations
 	type tr struct {

sqlx_test.go

@@ -1460,47 +1460,6 @@ func TestEmbeddedMaps(t *testing.T) {
 	})
 }
 
-func TestIssue197(t *testing.T) {
-	// this test actually tests for a bug in database/sql:
-	//   https://github.com/golang/go/issues/13905
-	// this potentially makes _any_ named type that is an alias for []byte
-	// unsafe to use in a lot of different ways (basically, unsafe to hold
-	// onto after loading from the database).
-	t.Skip()
-
-	type mybyte []byte
-	type Var struct{ Raw json.RawMessage }
-	type Var2 struct{ Raw []byte }
-	type Var3 struct{ Raw mybyte }
-	RunWithSchema(defaultSchema, t, func(db *DB, t *testing.T, now string) {
-		var err error
-		var v, q Var
-		if err = db.Get(&v, `SELECT '{"a": "b"}' AS raw`); err != nil {
-			t.Fatal(err)
-		}
-		if err = db.Get(&q, `SELECT 'null' AS raw`); err != nil {
-			t.Fatal(err)
-		}
-
-		var v2, q2 Var2
-		if err = db.Get(&v2, `SELECT '{"a": "b"}' AS raw`); err != nil {
-			t.Fatal(err)
-		}
-		if err = db.Get(&q2, `SELECT 'null' AS raw`); err != nil {
-			t.Fatal(err)
-		}
-
-		var v3, q3 Var3
-		if err = db.QueryRow(`SELECT '{"a": "b"}' AS raw`).Scan(&v3.Raw); err != nil {
-			t.Fatal(err)
-		}
-		if err = db.QueryRow(`SELECT '{"c": "d"}' AS raw`).Scan(&q3.Raw); err != nil {
-			t.Fatal(err)
-		}
-		t.Fail()
-	})
-}
-
 type Valuer struct {
 	Val string
 }