fix(PAR-2812): remove check requiring ticket in title (#105)

Author: benkn

.github/actions/validate-pr/validate_pr.sh

@@ -65,7 +65,6 @@ function compare_versions() {
 
 
 SEMANTIC_PREFIXES="^(feat|fix|chore|ci|docs|style|refactor|perf|test)[(:]"
-JIRA_TICKET="([A-Z]+-[0-9]+)"
 VERSION_REGEX="v([0-9]+)\.([0-9]+)\.([0-9]+)"
 
 if [ "$PR_BRANCH" == "main" ] && [ "$TARGET_BRANCH" == "develop" ]; then
@@ -84,19 +83,12 @@ Details:
 - Current title: $PR_TITLE
 Action: Update the PR title to start with a valid semantic prefix
 Valid prefixes: feat:, fix:, chore:, ci:, docs:, style:, refactor:, perf:, test:
-Example: feat: Add new feature (ABC-123)
+Examples: 
+  feat(ABC-123): Add new feature 
+  docs: correct misspelling in readme 
 Note: You must push a new commit to update this validation result"
     exit 1
   fi
-
-  if [[ ! "$PR_TITLE" =~ $JIRA_TICKET ]]; then
-    echo "Error: Missing Jira ticket reference in PR title
-Details:
-- Current title: $PR_TITLE
-Action: Include a Jira ticket ID in the PR title using the format (ABC-123)
-Example: feat: Add new feature (ABC-123)"
-    exit 1
-  fi
 fi
 
 if [[ "$TARGET_BRANCH" == "main" ]]; then

.github/actions/validate-pr/validate_pr_test.sh

@@ -42,48 +42,31 @@ Details:
 - Current title: This is a PR title (ISSUE-1234)
 Action: Update the PR title to start with a valid semantic prefix
 Valid prefixes: feat:, fix:, chore:, ci:, docs:, style:, refactor:, perf:, test:
-Example: feat: Add new feature (ABC-123)
+Examples: 
+  feat(ABC-123): Add new feature 
+  docs: correct misspelling in readme 
 Note: You must push a new commit to update this validation result"
 
-echo Scenario: PR title missing Jira ticket for feature branch
-beforeEach
-
-# GIVEN
-export PR_TITLE="feat: This is a PR title"
 
-# WHEN
-ACTUAL="$($SCRIPT_DIR/validate_pr.sh)"
-
-# THEN
-expect "$?" "1"
-expect "$ACTUAL" "Error: Missing Jira ticket reference in PR title
-Details:
-- Current title: feat: This is a PR title
-Action: Include a Jira ticket ID in the PR title using the format (ABC-123)
-Example: feat: Add new feature (ABC-123)"
 
-echo Scenario: PR title missing Jira ticket for feature branch targeting hotfix branch
+echo Scenario: Valid PR title for feature branch
 beforeEach
 
 # GIVEN
-export PR_TITLE="feat: This is a PR title"
+export PR_TITLE="feat: This is a PR title (ISSUE-1234)"
 
 # WHEN
 ACTUAL="$($SCRIPT_DIR/validate_pr.sh)"
 
 # THEN
-expect "$?" "1"
-expect "$ACTUAL" "Error: Missing Jira ticket reference in PR title
-Details:
-- Current title: feat: This is a PR title
-Action: Include a Jira ticket ID in the PR title using the format (ABC-123)
-Example: feat: Add new feature (ABC-123)"
+expect "$?" "0"
+expect "PR title and branch name validation passed." "$ACTUAL"
 
-echo Scenario: Valid PR title for feature branch
+echo Scenario: Valid PR title without Jira ticket for feature branch
 beforeEach
 
 # GIVEN
-export PR_TITLE="feat: This is a PR title (ISSUE-1234)"
+export PR_TITLE="feat: This is a PR title without ticket"
 
 # WHEN
 ACTUAL="$($SCRIPT_DIR/validate_pr.sh)"