refactor: audition check as async allowing non-static checks

Author: lsipii

VirtualFinland.UserAPI/src/VirtualFinland.UsersAPI/Activities/Productizer/ProductizerController.cs

@@ -159,7 +159,7 @@ public async Task<IActionResult> SaveOrUpdatePersonJobApplicantProfile(UpdateJob
                 e.Message);
             try
             {
-                var jwkToken = _authenticationService.ParseAuthenticationHeader(Request);
+                var jwkToken = await _authenticationService.ParseAuthenticationHeader(Request);
                 var query = new VerifyIdentityUser.Query(jwkToken.UserId, jwkToken.Issuer);
                 var createdUser = await _mediator.Send(query);
                 userId = createdUser.Id;

VirtualFinland.UserAPI/src/VirtualFinland.UsersAPI/Helpers/Services/AuthenticationService.cs

@@ -18,7 +18,7 @@ public AuthenticationService(UserSecurityService userSecurityService)
         return person.Id;
     }
 
-    public JwtTokenResult ParseAuthenticationHeader(HttpRequest httpRequest)
+    public Task<JwtTokenResult> ParseAuthenticationHeader(HttpRequest httpRequest)
     {
         var token = httpRequest.Headers.Authorization.ToString().Replace("Bearer ", string.Empty);
         return _userSecurityService.ParseJwtToken(token);

VirtualFinland.UserAPI/src/VirtualFinland.UsersAPI/Helpers/Services/UserSecurityService.cs

@@ -27,7 +27,7 @@ public UserSecurityService(UsersDbContext usersDbContext, ILogger<UserSecuritySe
     /// <exception cref="NotAuthorizedException">If user id and the issuer are not found in the DB for any given user, this is not a valid user within the users database.</exception>
     public async Task<Person> VerifyAndGetAuthenticatedUser(string token)
     {
-        var jwtTokenResult = ParseJwtToken(token);
+        var jwtTokenResult = await ParseJwtToken(token);
 
         try
         {
@@ -44,7 +44,7 @@ public async Task<Person> VerifyAndGetAuthenticatedUser(string token)
     /// <summary>
     /// Parses the JWT token and returns the issuer and the user id
     /// </summary>
-    public JwtTokenResult ParseJwtToken(string token)
+    public Task<JwtTokenResult> ParseJwtToken(string token)
     {
         return _applicationSecurity.ParseJwtToken(token);
     }

VirtualFinland.UserAPI/src/VirtualFinland.UsersAPI/Security/ApplicationSecurity.cs

@@ -17,7 +17,7 @@ public ApplicationSecurity(List<ISecurityFeature> features)
     /// <summary>
     /// Parses the JWT token and returns the issuer and the user id
     /// </summary>
-    public JwtTokenResult ParseJwtToken(string token)
+    public async Task<JwtTokenResult> ParseJwtToken(string token)
     {
         if (string.IsNullOrEmpty(token)) throw new NotAuthorizedException("No token provided");
 
@@ -32,7 +32,7 @@ public JwtTokenResult ParseJwtToken(string token)
 
         // Resolve and validate the token audience
         var tokenAudience = parsedToken.Audiences.FirstOrDefault() ?? throw new NotAuthorizedException("The given token audience is not valid");
-        securityFeature.ValidateSecurityTokenAudience(tokenAudience);
+        await securityFeature.ValidateSecurityTokenAudience(tokenAudience);
 
         // Resolve user id
         var userId = securityFeature.ResolveTokenUserId(parsedToken) ?? throw new NotAuthorizedException("The given token claim is not valid");

VirtualFinland.UserAPI/src/VirtualFinland.UsersAPI/Security/Features/ISecurityFeature.cs

@@ -10,7 +10,7 @@ public interface ISecurityFeature
     void BuildAuthorization(AuthorizationOptions options);
     string GetSecurityPolicySchemeName();
     string? ResolveTokenUserId(JwtSecurityToken jwtSecurityToken);
-    void ValidateSecurityTokenAudience(string audience);
+    Task ValidateSecurityTokenAudience(string audience);
 
     public string Issuer { get; }
 }

VirtualFinland.UserAPI/src/VirtualFinland.UsersAPI/Security/IApplicationSecurity.cs

@@ -2,5 +2,5 @@ namespace VirtualFinland.UserAPI.Security.Models;
 
 public interface IApplicationSecurity
 {
-    JwtTokenResult ParseJwtToken(string token);
+    Task<JwtTokenResult> ParseJwtToken(string token);
 }