fix: use the same ef pattern for storing lists of strings as elsewhere in project

Author: lsipii

VirtualFinland.UserAPI/src/VirtualFinland.UsersAPI/Data/Configuration/ExternalIdentityConfiguration.cs

@@ -0,0 +1,18 @@
+using Microsoft.EntityFrameworkCore;
+using Microsoft.EntityFrameworkCore.Metadata.Builders;
+using VirtualFinland.UserAPI.Helpers;
+using VirtualFinland.UserAPI.Models.UsersDatabase;
+
+namespace VirtualFinland.UserAPI.Data.Configuration;
+
+public class ExternalIdentityConfiguration : IEntityTypeConfiguration<ExternalIdentity>
+{
+    public void Configure(EntityTypeBuilder<ExternalIdentity> entity)
+    {
+        _ = entity.Property(c => c.Audiences).HasConversion(
+            v => string.Join(',', v ?? new List<string>()),
+            v => v.Split(',', StringSplitOptions.RemoveEmptyEntries).ToList(),
+            new CommaSeparatedListComparator()
+        );
+    }
+}

VirtualFinland.UserAPI/src/VirtualFinland.UsersAPI/Data/UsersDBContext.cs

@@ -48,6 +48,7 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
         modelBuilder.ApplyConfiguration(new WorkPreferencesConfiguration());
         modelBuilder.ApplyConfiguration(new CertificationConfiguration());
         modelBuilder.ApplyConfiguration(new TermsOfServiceConfiguration());
+        modelBuilder.ApplyConfiguration(new ExternalIdentityConfiguration());
 
         if (_isTesting) modelBuilder.ApplyConfiguration(new SearchProfileConfiguration());
     }

VirtualFinland.UserAPI/src/VirtualFinland.UsersAPI/Migrations/20231027073616_AddAudienceToExternalId.cs

@@ -11,12 +11,12 @@ protected override void Up(MigrationBuilder migrationBuilder)
             migrationBuilder.AddColumn<List<string>>(
                 name: "Audiences",
                 table: "ExternalIdentities",
-                type: "text[]",
+                type: "text",
                 nullable: true);
 
             migrationBuilder.Sql(@"
-                UPDATE ""ExternalIdentities"" SET ""Audiences"" = array['6fa88191-477e-4082-a119-e1e3ad09b7be'] WHERE ""Audiences"" IS NULL AND ""Issuer"" = 'https://login.iam.qa.sinuna.fi';
-                UPDATE ""ExternalIdentities"" SET ""Audiences"" = array['e6a5a645-0cf6-48a1-9f08-3d72be3aceaf'] WHERE ""Audiences"" IS NULL AND ""Issuer"" = 'https://login.testbed.fi';
+                UPDATE ""ExternalIdentities"" SET ""Audiences"" = '6fa88191-477e-4082-a119-e1e3ad09b7be' WHERE ""Audiences"" IS NULL AND ""Issuer"" = 'https://login.iam.qa.sinuna.fi';
+                UPDATE ""ExternalIdentities"" SET ""Audiences"" = 'e6a5a645-0cf6-48a1-9f08-3d72be3aceaf' WHERE ""Audiences"" IS NULL AND ""Issuer"" = 'https://login.testbed.fi';
             ");
         }
 

VirtualFinland.UserAPI/src/VirtualFinland.UsersAPI/Migrations/UsersDbContextModelSnapshot.cs

@@ -156,7 +156,7 @@ protected override void BuildModel(ModelBuilder modelBuilder)
                         .HasColumnType("uuid");
 
                     b.Property<string>("Audiences")
-                        .HasColumnType("text[]");
+                        .HasColumnType("text");
 
                     b.Property<DateTime>("Created")
                         .HasColumnType("timestamp with time zone");