fix: use correct db identifier in the mvp-backup

Author: lsipii

.github/workflows/deploy-to-environment.yml

@@ -57,6 +57,7 @@ jobs:
         run: |
           pulumi stack select ${{ secrets.PULUMI_ORGANIZATION }}/${{ inputs.environment }}
           echo "DBIdentifier=$(pulumi stack output DBIdentifier)" >> $GITHUB_OUTPUT
+          echo "DBClusterIdentifier=$(pulumi stack output DBClusterIdentifier)" >> $GITHUB_OUTPUT
           echo "AdminFunctionArn=$(pulumi stack output AdminFunctionArn)" >> $GITHUB_OUTPUT
           echo "StackExists=true" >> $GITHUB_OUTPUT
         env:
@@ -87,7 +88,7 @@ jobs:
       - name: Create database backup snapshot on PRE-deployment
         if: ${{ steps.deployment-database-events.outputs.Migrations == 'true' && env.IS_MVP_DEPLOYMENT }}
         run: |
-          aws rds create-db-cluster-snapshot --db-cluster-identifier ${{ steps.get-pulumi-outputs.outputs.DBIdentifier }} --db-cluster-snapshot-identifier PRE-${{ env.DEPLOYMENT_EVENT_IDENT }}
+          aws rds create-db-cluster-snapshot --db-cluster-identifier ${{ steps.get-pulumi-outputs.outputs.DBClusterIdentifier }} --db-cluster-snapshot-identifier PRE-${{ env.DEPLOYMENT_EVENT_IDENT }}
       - name: Wait for the database snapshot to be ready
         if: ${{ steps.deployment-database-events.outputs.Migrations == 'true' && env.IS_MVP_DEPLOYMENT }}
         run: |

VirtualFinland.UsersAPI.Deployment/Features/PostgresDatabase.cs

@@ -114,6 +114,7 @@ public void SetupProductionPostgresDatabase(Config config, StackSetup stackSetup
         DatabaseConnectionString = Output.Format($"Host={DbEndpoint};Database={DbName};Username={DbUsername};Password={DbPassword}");
         DatabaseAdminConnectionString = Output.Format($"Host={DbEndpoint};Database={DbName};Username={DbAdminUsername};Password={DbAdminPassword}");
         DBIdentifier = dbInstance.Identifier;
+        DBClusterIdentifier = auroraCluster.ClusterIdentifier;
 
         LogGroup = cloudwatch.CreateLogGroup(stackSetup, "database", Output.Format($"/aws/rds/cluster/{auroraCluster.ClusterIdentifier}/postgresql"), 3);
     }
@@ -215,6 +216,7 @@ public void InvokeInitialDatabaseAuditLogTriggersSetupFunction(StackSetup stackS
     }
 
     public Output<string> DBIdentifier = default!;
+    public Output<string> DBClusterIdentifier = default!;
     public string DbUsername = default!;
     public Output<string> DbPassword = default!;
     public Output<string> DatabaseConnectionString = default!;

VirtualFinland.UsersAPI.Deployment/UsersAPIStack.cs

@@ -50,6 +50,7 @@ public UsersApiStack()
         ApplicationUrl = apiProvider.ApplicationUrl;
         LambdaId = usersApiFunction.LambdaFunctionId;
         DBIdentifier = database.DBIdentifier;
+        DBClusterIdentifier = database.DBClusterIdentifier;
         AuditLogSubscriptionFunctionArn = auditLogSubscriptionFunction.LambdaFunctionArn;
 
         var adminFunction = new AdminFunction(config, stackSetup, vpcSetup, dbAdminConnectionStringSecret, analyticsSqS);
@@ -80,6 +81,7 @@ private static bool IsProductionEnvironment()
     [Output] public Output<string>? ApplicationUrl { get; set; }
     [Output] public Output<string>? LambdaId { get; set; }
     [Output] public Output<string>? DBIdentifier { get; set; }
+    [Output] public Output<string>? DBClusterIdentifier { get; set; }
     [Output] public Output<string>? AdminFunctionArn { get; set; }
     [Output] public Output<string>? AuditLogSubscriptionFunctionArn { get; set; }
     [Output] public Output<string>? ElastiCacheClusterId { get; set; }