Skip to content

Commit 9fd014d

Browse files
committed
feat: add error handling to bad occupation save data
1 parent 4df46f2 commit 9fd014d

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

  • VirtualFinland.UserAPI/src/VirtualFinland.UsersAPI/Activities/User/Operations

VirtualFinland.UserAPI/src/VirtualFinland.UsersAPI/Activities/User/Operations/UpdateUser.cs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -294,11 +294,7 @@ private static ICollection<Occupation> GetUpdatedOccupations(
294294
continue;
295295
}
296296

297-
var existingOccupation = dbUserOccupations.FirstOrDefault(o => o.Id == occupation.Id);
298-
299-
// TODO: Return some error about invalid guid ?
300-
if (existingOccupation is null) continue;
301-
297+
var existingOccupation = dbUserOccupations.FirstOrDefault(o => o.Id == occupation.Id) ?? throw new BadRequestException("Invalid occupation ID");
302298
if (occupation.Delete is true)
303299
{
304300
dbUserOccupations.Remove(existingOccupation);

0 commit comments

Comments
 (0)