We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
1 parent 4df46f2 commit 9fd014dCopy full SHA for 9fd014d
1 file changed
VirtualFinland.UserAPI/src/VirtualFinland.UsersAPI/Activities/User/Operations/UpdateUser.cs
@@ -294,11 +294,7 @@ private static ICollection<Occupation> GetUpdatedOccupations(
294
continue;
295
}
296
297
- var existingOccupation = dbUserOccupations.FirstOrDefault(o => o.Id == occupation.Id);
298
-
299
- // TODO: Return some error about invalid guid ?
300
- if (existingOccupation is null) continue;
301
+ var existingOccupation = dbUserOccupations.FirstOrDefault(o => o.Id == occupation.Id) ?? throw new BadRequestException("Invalid occupation ID");
302
if (occupation.Delete is true)
303
{
304
dbUserOccupations.Remove(existingOccupation);
0 commit comments