Skip to content

Commit 631ddac

Browse files
committed
faet: fix default onEvaluate
and types for addresses import
1 parent 485b016 commit 631ddac

3 files changed

Lines changed: 7 additions & 8 deletions

File tree

examples/acp_base/external_evaluation/env.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ function getEnvVar<T extends string = string>(key: string, required = true): T {
1313

1414
export const WHITELISTED_WALLET_PRIVATE_KEY = getEnvVar<Address>('WHITELISTED_WALLET_PRIVATE_KEY');
1515
export const WHITELISTED_WALLET_ENTITY_ID = parseInt(getEnvVar('WHITELISTED_WALLET_ENTITY_ID'), 10);
16-
export const BUYER_WALLET_ADDRESS = getEnvVar('BUYER_WALLET_ADDRESS') as Address;
17-
export const SELLER_WALLET_ADDRESS = getEnvVar<Address>('SELLER_WALLET_ADDRESS') as Address;
18-
export const EVALUATOR_WALLET_ADDRESS = getEnvVar<Address>('EVALUATOR_WALLET_ADDRESS') as Address;
16+
export const BUYER_WALLET_ADDRESS = getEnvVar<Address>('BUYER_WALLET_ADDRESS');
17+
export const SELLER_WALLET_ADDRESS = getEnvVar<Address>('SELLER_WALLET_ADDRESS');
18+
export const EVALUATOR_WALLET_ADDRESS = getEnvVar<Address>('EVALUATOR_WALLET_ADDRESS');
1919

2020
if (isNaN(WHITELISTED_WALLET_ENTITY_ID)) {
2121
throw new Error('WHITELISTED_WALLET_ENTITY_ID must be a valid number in the .env file');

examples/acp_base/self_evaluation/env.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,8 @@ function getEnvVar<T extends string = string>(key: string, required = true): T {
1313

1414
export const WHITELISTED_WALLET_PRIVATE_KEY = getEnvVar<Address>('WHITELISTED_WALLET_PRIVATE_KEY');
1515
export const WHITELISTED_WALLET_ENTITY_ID = parseInt(getEnvVar('WHITELISTED_WALLET_ENTITY_ID'), 10);
16-
export const BUYER_WALLET_ADDRESS = getEnvVar('BUYER_WALLET_ADDRESS') as Address;
17-
export const SELLER_WALLET_ADDRESS = getEnvVar<Address>('SELLER_WALLET_ADDRESS') as Address;
18-
export const EVALUATOR_WALLET_ADDRESS = getEnvVar<Address>('EVALUATOR_WALLET_ADDRESS') as Address;
16+
export const BUYER_WALLET_ADDRESS = getEnvVar<Address>('BUYER_WALLET_ADDRESS');
17+
export const SELLER_WALLET_ADDRESS = getEnvVar<Address>('SELLER_WALLET_ADDRESS');
1918

2019
if (isNaN(WHITELISTED_WALLET_ENTITY_ID)) {
2120
throw new Error('WHITELISTED_WALLET_ENTITY_ID must be a valid number in the .env file');

src/acpClient.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ class AcpClient {
8989
this.init();
9090
}
9191

92-
private async defaultOnEvaluate(_: AcpJob) {
93-
return new EvaluateResult(true, "Evaluated by default");
92+
private async defaultOnEvaluate(job: AcpJob) {
93+
await job.evaluate(true, "Evaluated by default");
9494
}
9595

9696
async init() {

0 commit comments

Comments
 (0)