refactor: remove unnecessary variable declaration

Ang-dot · Ang-dot · commit e355d06ad2a7 · 2025-12-03T16:20:38.000+08:00
diff --git a/virtuals_acp/contract_clients/base_contract_client.py b/virtuals_acp/contract_clients/base_contract_client.py
@@ -90,10 +90,8 @@ def validate_session_key_on_chain(
                 .signers(session_entity_key_id, self.agent_wallet_address)
                 .call()
         )
-        expected = on_chain_signer_address
-        given = session_signer_address
 
-        if is_none_or_zero_address(expected):
+        if is_none_or_zero_address(on_chain_signer_address):
             raise ACPError(
                 "ACP Contract Client validation failed:\n" +
                 json.dumps(
@@ -106,7 +104,7 @@ def validate_session_key_on_chain(
                 )
             )
 
-        if expected.lower() != given.lower():
+        if on_chain_signer_address.lower() != session_signer_address.lower():
             raise ACPError(
                 "ACP Contract Client validation failed:\n" +
                 json.dumps(

Original file line number	Diff line number	Diff line change
`@@ -90,10 +90,8 @@ def validate_session_key_on_chain(`
`90`	`90`	`.signers(session_entity_key_id, self.agent_wallet_address)`
`91`	`91`	`.call()`
`92`	`92`	`)`
`93`		`- expected = on_chain_signer_address`
`94`		`- given = session_signer_address`
`95`	`93`
`96`		`- if is_none_or_zero_address(expected):`
	`94`	`+ if is_none_or_zero_address(on_chain_signer_address):`
`97`	`95`	`raise ACPError(`
`98`	`96`	`"ACP Contract Client validation failed:\n" +`
`99`	`97`	`json.dumps(`
`@@ -106,7 +104,7 @@ def validate_session_key_on_chain(`
`106`	`104`	`)`
`107`	`105`	`)`
`108`	`106`
`109`		`- if expected.lower() != given.lower():`
	`107`	`+ if on_chain_signer_address.lower() != session_signer_address.lower():`
`110`	`108`	`raise ACPError(`
`111`	`109`	`"ACP Contract Client validation failed:\n" +`
`112`	`110`	`json.dumps(`