Fixing a bug preventing in-plane slice from updating properly

Author: dbirman

Assets/Scripts/TrajectoryPlanner/Controllers/DefaultProbeController.cs

@@ -783,7 +783,6 @@ public override void SetProbePosition(ProbeInsertion localInsertion)
     /// <returns></returns>
     public override (Vector3 tipCoordWorld, Vector3 tipUpWorld, Vector3 tipForwardWorld) GetTipWorld()
     {
-        Debug.Log((_probeTipT.up, _probeTipT.forward));
         Vector3 tipCoordWorld = WorldT2WorldU(_probeTipT.position);
         Vector3 tipUpWorld = (WorldT2WorldU(_probeTipT.position + _probeTipT.up) - tipCoordWorld).normalized;
         Vector3 tipForwardWorld = (WorldT2WorldU(_probeTipT.position + _probeTipT.forward) - tipCoordWorld).normalized;

Assets/Scripts/TrajectoryPlanner/ProbeManager.cs

@@ -122,6 +122,11 @@ private void Awake()
         visibleOtherColliders = new Dictionary<GameObject, Material>();
     }
 
+    private void Start()
+    {
+        Debug.Log(string.Format("New probe created with UUID: {0}", _uuid));
+    }
+
     /// <summary>
     /// Called by Unity when this object is destroyed. 
     /// Unregisters the probe from tpmanager
@@ -176,6 +181,14 @@ public void SetUIVisibility(bool state)
     }
 
 
+    public void OverrideUUID(string newUUID)
+    {
+#if UNITY_EDITOR
+        Debug.Log(string.Format("Override UUID to {0}", newUUID));
+#endif
+        _uuid = newUUID;
+    }
+
     /// <summary>
     /// Update the size of the recording region.
     /// </summary>

Assets/Scripts/TrajectoryPlanner/TP_InPlaneSlice.cs

@@ -31,7 +31,7 @@ public class TP_InPlaneSlice : MonoBehaviour
     private int zoomLevel = 0;
     private float zoomFactor = 1f;
 
-    private RectTransform rect;
+    private RectTransform _rect;
 
     private Texture3D annotationDatasetGPUTexture;
     private TaskCompletionSource<bool> gpuTextureLoadedSource;
@@ -44,7 +44,7 @@ public class TP_InPlaneSlice : MonoBehaviour
 
     private void Awake()
     {
-        rect = GetComponent<RectTransform>();
+        _rect = GetComponent<RectTransform>();
 
         gpuTextureLoadedSource = new TaskCompletionSource<bool>();
         gpuTextureLoadedTask = gpuTextureLoadedSource.Task;
@@ -116,7 +116,7 @@ public void UpdateInPlaneSlice()
         }
 
         (Vector3 startCoordWorld, Vector3 endCoordWorld) = activeProbeManager.GetProbeController().GetRecordingRegionWorld();
-        (_, Vector3 upWorld, Vector3 forwardWorld) = activeProbeManager.GetProbeController().GetTipWorld();
+        (_, upWorld, forwardWorld) = activeProbeManager.GetProbeController().GetTipWorld();
 
 #if UNITY_EDITOR
         // debug statements
@@ -171,22 +171,20 @@ public void InPlaneSliceHover(Vector2 pointerData)
     private Vector3 CalculateInPlanePosition(Vector2 pointerData)
     {
         Vector2 inPlanePosNorm = GetLocalRectPosNormalized(pointerData) * inPlaneScale / 2;
-
         // Take the tip transform and go out according to the in plane percentage 
         Vector3 inPlanePosition = recordingRegionCenterPosition + (annotationDataset.CoordinateSpace.World2SpaceAxisChange(forwardWorld) * -inPlanePosNorm.x + annotationDataset.CoordinateSpace.World2SpaceAxisChange(upWorld) * inPlanePosNorm.y);
-
         return inPlanePosition;
     }
 
     // Return the position within the local UI rectangle scaled to [-1, 1] on each axis
     private Vector2 GetLocalRectPosNormalized(Vector2 pointerData)
     {
         Vector2 inPlanePosNorm;
-        RectTransformUtility.ScreenPointToLocalPointInRectangle(rect, pointerData, Camera.main, out inPlanePosNorm);
+        RectTransformUtility.ScreenPointToLocalPointInRectangle(_rect, pointerData, Camera.main, out inPlanePosNorm);
 
-        inPlanePosNorm += new Vector2(rect.rect.width, rect.rect.height / 2);
-        inPlanePosNorm.x = inPlanePosNorm.x / rect.rect.width * 2 - 1;
-        inPlanePosNorm.y = inPlanePosNorm.y / rect.rect.height * 2 - 1;
+        inPlanePosNorm += new Vector2(_rect.rect.width, _rect.rect.height / 2);
+        inPlanePosNorm.x = inPlanePosNorm.x / _rect.rect.width * 2 - 1;
+        inPlanePosNorm.y = inPlanePosNorm.y / _rect.rect.height * 2 - 1;
         return inPlanePosNorm;
     }
 

Assets/Scripts/TrajectoryPlanner/TP_SliceRenderer.cs

@@ -149,7 +149,6 @@ private void Update()
     /// </summary>
     private void UpdateSlicePosition()
     {
-        Debug.Log("Update slice called: " + Time.realtimeSinceStartup);
         ProbeManager activeProbeManager = tpmanager.GetActiveProbeManager();
         if (activeProbeManager == null) return;