Fixing a bug that caused slice renderer shader properties to activate even when disabled

Author: dbirman

Assets/Scripts/TrajectoryPlanner/TP_SliceRenderer.cs

@@ -144,25 +144,28 @@ private void Update()
     /// </summary>
     public void UpdateSlicePosition()
     {
-        ProbeManager activeProbeManager = tpmanager.GetActiveProbeManager();
-        if (activeProbeManager == null) return;
+        if (localPrefs.GetSlice3D() > 0)
+        {
+            ProbeManager activeProbeManager = tpmanager.GetActiveProbeManager();
+            if (activeProbeManager == null) return;
 
-        // the actual tip
-        Vector3 probeTipWorld = activeProbeManager.GetProbeController().ProbeTipT.position;
-        // position the slices along the real tip in world space
-        coronalSliceGO.transform.position = new Vector3(0f, 0f, probeTipWorld.z);
-        sagittalSliceGO.transform.position = new Vector3(probeTipWorld.x, 0f, 0f);
+            // the actual tip
+            Vector3 probeTipWorld = activeProbeManager.GetProbeController().ProbeTipT.position;
+            // position the slices along the real tip in world space
+            coronalSliceGO.transform.position = new Vector3(0f, 0f, probeTipWorld.z);
+            sagittalSliceGO.transform.position = new Vector3(probeTipWorld.x, 0f, 0f);
 
-        // for CCF coordinates
-        (Vector3 tipCoordWorld, _, _) = activeProbeManager.GetProbeController().GetTipWorldU();
+            // for CCF coordinates
+            (Vector3 tipCoordWorld, _, _) = activeProbeManager.GetProbeController().GetTipWorldU();
 
-        apWorldmm = tipCoordWorld.z + 6.6f;
-        coronalSliceMaterial.SetFloat("_SlicePosition", apWorldmm / 13.2f);
+            apWorldmm = tipCoordWorld.z + 6.6f;
+            coronalSliceMaterial.SetFloat("_SlicePosition", apWorldmm / 13.2f);
 
-        mlWorldmm = -(tipCoordWorld.x - 5.7f);
-        saggitalSliceMaterial.SetFloat("_SlicePosition", mlWorldmm / 11.4f);
+            mlWorldmm = -(tipCoordWorld.x - 5.7f);
+            saggitalSliceMaterial.SetFloat("_SlicePosition", mlWorldmm / 11.4f);
 
-        UpdateNodeModelSlicing();
+            UpdateNodeModelSlicing();
+        }
     }
 
     private void UpdateCameraPosition()
@@ -193,7 +196,7 @@ private void UpdateCameraPosition()
             UpdateNodeModelSlicing();
     }
 
-        private void UpdateNodeModelSlicing()
+    private void UpdateNodeModelSlicing()
     {
         // Update the renderers on the node objects
         foreach (CCFTreeNode node in modelControl.GetDefaultLoadedNodes())
@@ -224,6 +227,7 @@ private void ClearNodeModelSlicing()
 
     public void ToggleSliceVisibility(int sliceType)
     {
+        Debug.Log(sliceType);
         localPrefs.SetSlice3D(sliceType);
 
         if (sliceType==0)