Fixing a really bad bug in InPlaneSlice

- Bug was causing the forward direction to be incorrectly calculated because you can't pass normalized vectors through W2T or T2W!!
- Fixed by calculating a point in TransformedWorld space to represent the up and forward directions and then returning those in normalized UnityWorld coordinates

Author: dbirman

Assets/Scripts/TrajectoryPlanner/Controllers/DefaultProbeController.cs

@@ -783,10 +783,11 @@ public override void SetProbePosition(ProbeInsertion localInsertion)
     /// <returns></returns>
     public override (Vector3 tipCoordWorld, Vector3 tipUpWorld, Vector3 tipForwardWorld) GetTipWorld()
     {
+        Debug.Log((_probeTipT.up, _probeTipT.forward));
         Vector3 tipCoordWorld = WorldT2WorldU(_probeTipT.position);
-        //Vector3 tipUpWorld = (WorldT2WorldU(probeTipTop.transform.position) - tipCoordWorld).normalized;
-        Vector3 tipUpWorld = WorldT2WorldU(_probeTipT.up).normalized;
-        Vector3 tipForwardWorld = WorldT2WorldU(_probeTipT.forward).normalized;
+        Vector3 tipUpWorld = (WorldT2WorldU(_probeTipT.position + _probeTipT.up) - tipCoordWorld).normalized;
+        Vector3 tipForwardWorld = (WorldT2WorldU(_probeTipT.position + _probeTipT.forward) - tipCoordWorld).normalized;
+
         return (tipCoordWorld, tipUpWorld, tipForwardWorld);
     }
 
@@ -823,7 +824,7 @@ public override (Vector3 startCoordWorld, Vector3 endCoordWorld) GetRecordingReg
         }
         else
         {
-            return (WorldT2WorldU(tipTransform.position), WorldT2WorldU(tipTransform.position));
+            return (WorldT2WorldU(tipTransform.position), WorldT2WorldU(tipTransform.position + tipTransform.up * 10f));
         }
     }
 

Assets/Scripts/TrajectoryPlanner/TP_InPlaneSlice.cs

@@ -103,11 +103,6 @@ public void UpdateInPlaneVisibility()
         inPlaneSliceUIGO.SetActive(localPrefs.GetInplane());
     }
 
-    private void Update()
-    {
-        UpdateInPlaneSlice();
-    }
-
     public void UpdateInPlaneSlice()
     {
         if (!localPrefs.GetInplane()) return;
@@ -122,8 +117,6 @@ public void UpdateInPlaneSlice()
 
         (Vector3 startCoordWorld, Vector3 endCoordWorld) = activeProbeManager.GetProbeController().GetRecordingRegionWorld();
         (_, Vector3 upWorld, Vector3 forwardWorld) = activeProbeManager.GetProbeController().GetTipWorld();
-        upWorld = (endCoordWorld - startCoordWorld).normalized;
-        forwardWorld = Quaternion.Euler(-90f, 0f, 0f) * upWorld;
 
 #if UNITY_EDITOR
         // debug statements