fix!(stylelint): remove sass support (#539)

* fix!(stylelint): remove sass support

* Create fresh-jars-tickle.md

Signed-off-by: Kentaro Suzuki <71284054+sushichan044@users.noreply.github.com>

* chore: update snapshot (github-actions)

---------

Signed-off-by: Kentaro Suzuki <71284054+sushichan044@users.noreply.github.com>
Co-authored-by: robo-miku[bot] <185786754+robo-miku[bot]@users.noreply.github.com>

Author: sushichan044

.changeset/fresh-jars-tickle.md

@@ -0,0 +1,5 @@
+---
+"@virtual-live-lab/stylelint-config": major
+---
+
+fix!(stylelint): remove sass support

README.md

@@ -11,7 +11,7 @@
 - Prettier: `@virtual-live-lab/prettier-config`
   - Code formatter for JavaScript / TypeScript / CSS and more
 - Stylelint: `@virtual-live-lab/stylelint-config`
-  - Lint / error check for CSS / SCSS
+  - Lint / error check for CSS
 - TypeScript: `@virtual-live-lab/tsconfig`
   - TypeScript configuration presets
 

packages/stylelint-config/README.md

@@ -30,29 +30,6 @@ import createConfig from "@virtual-live-lab/stylelint-config";
 export default createConfig();
 ```
 
-### Use for sass / scss
-
-```bash
-npm install stylelint \
-  @virtual-live-lab/stylelint-config \
-  @double-great/stylelint-a11y \
-  stylelint-declaration-block-no-ignored-properties \
-  stylelint-value-no-unknown-custom-properties \
-  stylelint-config-recommended \
-  stylelint-config-standard \
-  stylelint-config-recess-order \
-  stylelint-config-standard-scss \
-  stylelint-config-sass-guidelines \
-  --save-dev
-```
-
-```js
-// stylelint.config.mjs
-import createConfig from "@virtual-live-lab/stylelint-config";
-
-export default createConfig({ sass: true });
-```
-
 ### Use for Astro
 
 > [!TIP]
@@ -71,8 +48,6 @@ npm install stylelint \
   stylelint-config-recommended \
   stylelint-config-standard \
   stylelint-config-recess-order \
-  stylelint-config-standard-scss \
-  stylelint-config-sass-guidelines \
   stylelint-config-html \
   --save-dev
 ```
@@ -83,12 +58,11 @@ import createConfig from "@virtual-live-lab/stylelint-config";
 
 export default createConfig({
   astro: true,
-  // enable sass if you use sass / scss
-  sass: true,
 });
 ```
 
 ### a11y rules
+
 a11y rules are enabled by default. If you **do not** want to use a11y rules, you can disable it.
 
 ```js
@@ -99,6 +73,7 @@ export default createConfig({ a11y: false });
 ```
 
 ### tailwindcss rules
+
 If you use tailwindcss, you can enable tailwindcss rules.
 
 ```js
@@ -120,7 +95,6 @@ import createConfig from "@virtual-live-lab/stylelint-config";
 
 export default createConfig({
   tailwindcss: true,
-  sass: true,
   astro: true,
 },
 {

packages/stylelint-config/docs/vscode-setup.md

@@ -22,7 +22,7 @@ VLLでは基本的にVSCodeの利用を推奨しています。ここではVSCod
   "editor.codeActionsOnSave": {
     "source.fixAll.stylelint": "explicit"
   },
-  "stylelint.validate": ["css", "postcss", "scss"],
+  "stylelint.validate": ["css", "postcss"],
   "stylelint.packageManager": "PROJECT_PACKAGE_MANAGER"
 }
 ```
@@ -33,6 +33,6 @@ VLLでは基本的にVSCodeの利用を推奨しています。ここではVSCod
 
 ```json
 {
-  "stylelint.validate": ["css", "postcss", "scss", "astro"]
+  "stylelint.validate": ["css", "postcss", "astro"]
 }
 ```

packages/stylelint-config/package.json

@@ -10,14 +10,6 @@
     ".": {
       "types": "./dist/index.d.ts",
       "import": "./dist/index.js"
-    },
-    "./scss": {
-      "types": "./dist/scss.d.ts",
-      "import": "./dist/scss.js"
-    },
-    "./astro": {
-      "types": "./dist/astro.d.ts",
-      "import": "./dist/astro.js"
     }
   },
   "files": [
@@ -40,9 +32,7 @@
     "defu": "6.1.4",
     "stylelint-config-html": "1.1.0",
     "stylelint-config-recess-order": "7.2.0",
-    "stylelint-config-sass-guidelines": "12.1.0",
     "stylelint-config-standard": "39.0.0",
-    "stylelint-config-standard-scss": "15.0.1",
     "stylelint-declaration-block-no-ignored-properties": "2.8.0",
     "stylelint-value-no-unknown-custom-properties": "6.0.1"
   },

packages/stylelint-config/src/astro.ts

@@ -4,6 +4,6 @@ import type { Config } from "stylelint";
 
 import { createConfig } from "./factory";
 
-const config: Config = createConfig({ astro: true, sass: true });
+const config: Config = createConfig({ astro: true });
 
 export default config;

packages/stylelint-config/src/config/tailwind.ts

@@ -1,15 +1,14 @@
 import type { Config } from "stylelint";
 
-import { astroFiles, cssFiles, sassFiles } from "../files";
+import { astroFiles, cssFiles } from "../files";
 import { mergeConfigs } from "../util";
 
 type TailwindOptions = {
   astro: boolean;
-  sass: boolean;
 };
 
 export const tailwindConfig = (options: TailwindOptions): Config => {
-  const { astro, sass } = options;
+  const { astro } = options;
 
   const configs: Config[] = [];
 
@@ -36,20 +35,20 @@ export const tailwindConfig = (options: TailwindOptions): Config => {
     ],
   });
 
-  if (sass) {
-    // enable for sass
+  if (astro) {
+    // enable for astro with css
     configs.push({
       overrides: [
         {
-          files: sassFiles,
+          files: astroFiles,
           rules: {
             "at-rule-no-deprecated": [
               true,
               {
                 ignoreAtRules: tailwindDeprecatedAtRules,
               },
             ],
-            "scss/at-rule-no-unknown": [
+            "at-rule-no-unknown": [
               true,
               {
                 ignoreAtRules: tailwindAtRules,
@@ -61,56 +60,6 @@ export const tailwindConfig = (options: TailwindOptions): Config => {
     });
   }
 
-  if (astro) {
-    if (sass) {
-      // enable for astro with sass
-      configs.push({
-        overrides: [
-          {
-            files: astroFiles,
-            rules: {
-              "at-rule-no-deprecated": [
-                true,
-                {
-                  ignoreAtRules: tailwindDeprecatedAtRules,
-                },
-              ],
-              "scss/at-rule-no-unknown": [
-                true,
-                {
-                  ignoreAtRules: tailwindAtRules,
-                },
-              ],
-            },
-          },
-        ],
-      });
-    } else {
-      // enable for astro with css
-      configs.push({
-        overrides: [
-          {
-            files: astroFiles,
-            rules: {
-              "at-rule-no-deprecated": [
-                true,
-                {
-                  ignoreAtRules: tailwindDeprecatedAtRules,
-                },
-              ],
-              "at-rule-no-unknown": [
-                true,
-                {
-                  ignoreAtRules: tailwindAtRules,
-                },
-              ],
-            },
-          },
-        ],
-      });
-    }
-  }
-
   return mergeConfigs(configs.at(0), ...configs.slice(1));
 };
 

packages/stylelint-config/src/factory.ts

@@ -1,7 +1,7 @@
 import type { Config } from "stylelint";
 
 import { tailwindConfig } from "./config/tailwind";
-import { astroFiles, sassFiles } from "./files";
+import { astroFiles } from "./files";
 import { mergeConfigs } from "./util";
 
 type PresetOptions = {
@@ -23,12 +23,6 @@ type PresetOptions = {
    * @default false
    */
   cssModulesKit?: boolean;
-  /**
-   * Enable sass / scss rules.
-   *
-   * @default false
-   */
-  sass?: boolean;
   /**
    * Enable tailwindcss rules.
    *
@@ -55,7 +49,6 @@ export const createConfig = (
     a11y = true,
     astro = false,
     cssModulesKit = false,
-    sass = false,
     tailwindcss = false,
   } = options;
 
@@ -89,80 +82,7 @@ export const createConfig = (
     });
   }
 
-  if (sass) {
-    configs.push({
-      overrides: [
-        {
-          extends: [
-            "stylelint-config-standard-scss",
-            "stylelint-config-sass-guidelines",
-          ],
-          files: sassFiles,
-          name: "@virtual-live-lab/stylelint-config/sass",
-          rules: {
-            // see: https://github.com/VirtualLiveLab/js-config/issues/178
-            "@stylistic/block-opening-brace-space-before": null,
-            "@stylistic/color-hex-case": null,
-            "@stylistic/declaration-bang-space-after": null,
-            "@stylistic/declaration-bang-space-before": null,
-            "@stylistic/declaration-block-semicolon-newline-after": null,
-            "@stylistic/declaration-block-semicolon-space-before": null,
-            "@stylistic/declaration-block-trailing-semicolon": null,
-            "@stylistic/declaration-colon-space-after": null,
-            "@stylistic/declaration-colon-space-before": null,
-            "@stylistic/function-comma-space-after": null,
-            "@stylistic/function-parentheses-space-inside": null,
-            "@stylistic/indentation": null,
-            "@stylistic/media-feature-parentheses-space-inside": null,
-            "@stylistic/no-missing-end-of-source-newline": null,
-            "@stylistic/number-leading-zero": null,
-            "@stylistic/number-no-trailing-zeros": null,
-            "@stylistic/selector-list-comma-newline-after": null,
-            "@stylistic/string-quotes": null,
-          },
-        },
-      ],
-    });
-  }
-
   if (astro) {
-    // extends: ["stylelint-config-html/astro"] は最後に override に追加しないとパーサーの設定が壊れる
-    if (sass) {
-      configs.push({
-        overrides: [
-          {
-            extends: [
-              "stylelint-config-standard-scss",
-              "stylelint-config-sass-guidelines",
-            ],
-            files: astroFiles,
-            name: "@virtual-live-lab/stylelint-config/astro/sass",
-            rules: {
-              // see: https://github.com/VirtualLiveLab/js-config/issues/178
-              "@stylistic/block-opening-brace-space-before": null,
-              "@stylistic/color-hex-case": null,
-              "@stylistic/declaration-bang-space-after": null,
-              "@stylistic/declaration-bang-space-before": null,
-              "@stylistic/declaration-block-semicolon-newline-after": null,
-              "@stylistic/declaration-block-semicolon-space-before": null,
-              "@stylistic/declaration-block-trailing-semicolon": null,
-              "@stylistic/declaration-colon-space-after": null,
-              "@stylistic/declaration-colon-space-before": null,
-              "@stylistic/function-comma-space-after": null,
-              "@stylistic/function-parentheses-space-inside": null,
-              "@stylistic/indentation": null,
-              "@stylistic/media-feature-parentheses-space-inside": null,
-              "@stylistic/no-missing-end-of-source-newline": null,
-              "@stylistic/number-leading-zero": null,
-              "@stylistic/number-no-trailing-zeros": null,
-              "@stylistic/selector-list-comma-newline-after": null,
-              "@stylistic/string-quotes": null,
-            },
-          },
-        ],
-      });
-    }
-
     // この push が astro 向け override の最後であることを確認すること
     configs.push({
       overrides: [
@@ -176,7 +96,7 @@ export const createConfig = (
   }
 
   if (tailwindcss) {
-    configs.push(tailwindConfig({ astro, sass }));
+    configs.push(tailwindConfig({ astro }));
   }
 
   if (cssModulesKit) {

packages/stylelint-config/src/files.ts

@@ -1,13 +1,5 @@
 // css
 export const cssFiles = ["*.css", "**/*.css"] as const satisfies string[];
 
-// sass
-const _sassFiles = ["*.sass", "**/*.sass"] as const satisfies string[];
-const _scssFiles = ["*.scss", "**/*.scss"] as const satisfies string[];
-export const sassFiles = [
-  ..._sassFiles,
-  ..._scssFiles,
-] as const satisfies string[];
-
 // astro
 export const astroFiles = ["*.astro", "**/*.astro"] as const satisfies string[];