Skip to content

Commit 7cd4b81

Browse files
feat: prevent illegal useEffect usage (#566)
* chore(deps): add eslint-plugin-react-you-might-not-need-an-effect * feat: prevent illegal useEffect usage * Create silly-spoons-tease.md Signed-off-by: Kentaro Suzuki <71284054+sushichan044@users.noreply.github.com> * chore: update snapshot (github-actions) --------- Signed-off-by: Kentaro Suzuki <71284054+sushichan044@users.noreply.github.com> Co-authored-by: robo-miku[bot] <185786754+robo-miku[bot]@users.noreply.github.com>
1 parent b60b6da commit 7cd4b81

5 files changed

Lines changed: 119 additions & 53 deletions

File tree

.changeset/silly-spoons-tease.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@virtual-live-lab/eslint-config": minor
3+
---
4+
5+
feat(eslint): prevent illegal useEffect usage with eslint-plugin-react-you-might-not-need-an-effect

packages/eslint-config/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@
5151
"eslint-plugin-react": "7.37.5",
5252
"eslint-plugin-react-hooks": "7.0.1",
5353
"eslint-plugin-react-refresh": "0.4.24",
54+
"eslint-plugin-react-you-might-not-need-an-effect": "0.7.0",
5455
"eslint-plugin-tailwindcss": "3.18.2",
5556
"globals": "16.4.0",
5657
"package-directory": "8.1.0",

packages/eslint-config/src/base/react.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { defineConfig } from "@eslint/config-helpers";
22
import react from "eslint-plugin-react";
33
import reactHooks from "eslint-plugin-react-hooks";
44
import reactRefresh from "eslint-plugin-react-refresh";
5+
import reactYouMightNotNeedAnEffect from "eslint-plugin-react-you-might-not-need-an-effect";
56
import globals from "globals";
67

78
import { prepareForExtend } from "../utils/eslint";
@@ -15,6 +16,7 @@ const reactConfig = defineConfig({
1516
// @ts-expect-error type does not exists
1617
// eslint-disable-next-line @typescript-eslint/no-unsafe-argument, @typescript-eslint/no-unsafe-member-access
1718
reactHooks.configs["flat/recommended"],
19+
reactYouMightNotNeedAnEffect.configs.recommended,
1820
),
1921
files: [jsFiles, tsFiles],
2022
languageOptions: {

0 commit comments

Comments
 (0)