Skip to content

Commit 6e287ba

Browse files
authored
Merge pull request #110 from VirtualPlantLab/add_corner_case_tests_l
Add corner case tests
2 parents 620164a + a4d6011 commit 6e287ba

3 files changed

Lines changed: 503 additions & 2 deletions

File tree

src/dependencies/hard_dependencies.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,6 @@ function hard_dependencies(mapping::Dict{String,T}; verbose::Bool=true) where {T
125125
# it becomes harder to keep track of them as needed without traversing the graph
126126
# so keep tabs on them during initialisation until they're no longer needed
127127
hard_dependency_dict = Dict{Pair{Symbol, String}, HardDependencyNode}()
128-
hard_deps = Dict()
129128

130129
hard_deps = Dict()
131130

@@ -213,7 +212,7 @@ function hard_dependencies(mapping::Dict{String,T}; verbose::Bool=true) where {T
213212
# update their parent to the correct new node
214213
for ((hd_sym, hd_scale), hd_node) in hard_dependency_dict
215214

216-
if (hd_node.parent.process == p) && (hd_node.parent.scale == hd_scale)
215+
if (hd_node.parent.process == p) && (hd_node.scale == hd_scale)
217216
hd_node.parent = new_node
218217
end
219218
end

test/runtests.jl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,10 @@ using Documenter # for doctests
5757
include("test-mtg-multiscale-cyclic-dep.jl")
5858
end
5959

60+
@testset "Multiscale corner-cases" begin
61+
include("test-corner-cases.jl")
62+
end
63+
6064
if VERSION >= v"1.10"
6165
# Some formating changed in Julia 1.10, e.g. @NamedTuple instead of NamedTuple.
6266
@testset "Doctests" begin

0 commit comments

Comments
 (0)