Merge pull request #655 from VirtusLab-Open-Source/fix/wrapper-element-related

fix: wrapper element related

Author: mateusz-kleszcz

package.json

@@ -1,6 +1,6 @@
 {
   "name": "strapi-plugin-navigation",
-  "version": "3.3.4",
+  "version": "3.3.5",
   "description": "Strapi - Navigation plugin",
   "strapi": {
     "name": "navigation",

server/src/content-types/navigation-item/schema.ts

@@ -75,7 +75,7 @@ export default {
     related: {
       type: 'relation',
       relation: 'morphToMany',
-      required: true,
+      required: false,
       configurable: false,
     },
     parent: {

server/src/utils/migration.ts

@@ -7,6 +7,9 @@ export const removeNavigationsWithoutDefaultLocale = async (context: { strapi: C
     limit: Number.MAX_SAFE_INTEGER,
   });
   const defaultLocale = await context.strapi.plugin('i18n').service('locales').getDefaultLocale();
+  if (!defaultLocale) {
+    return;
+  }
   await Promise.all(
     allNavigations.map(async (navigation) => {
       const root = allNavigations.find(

server/tests/content-types/navigation-item.test.ts

@@ -66,7 +66,7 @@ describe('Navigation', () => {
     "related": {
       "configurable": false,
       "relation": "morphToMany",
-      "required": true,
+      "required": false,
       "type": "relation",
     },
     "title": {

server/tests/utils/migration.test.ts

@@ -272,6 +272,24 @@ describe('Navigation', () => {
         );
         expect(mockRepository.remove).not.toHaveBeenCalled();
       });
+
+      it('should return early without removing when defaultLocale is not defined', async () => {
+        // Given
+        const otherLocale = 'fr';
+        const documentId = faker.string.uuid();
+        const navigations = [getMockNavigation({ documentId, locale: otherLocale })];
+
+        mockI18nService.getDefaultLocale.mockResolvedValue(null);
+        mockRepository.find.mockResolvedValue(navigations);
+
+        // When
+        await removeNavigationsWithoutDefaultLocale({ strapi: mockStrapi });
+
+        // Then
+        expect(mockRepository.find).toHaveBeenCalled();
+        expect(mockI18nService.getDefaultLocale).toHaveBeenCalled();
+        expect(mockRepository.remove).not.toHaveBeenCalled();
+      });
     });
   });
 });