Skip to content

Commit 304c53d

Browse files
author
Bill Bensing
committed
changed the name of functions
1 parent 40194e5 commit 304c53d

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

src/main/java/com/wb3tech/kernel/valueobject/Money.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,17 +44,17 @@ public Money Minus(Money money) {
4444
return new Money(totalAmount, this.currency);
4545
}
4646

47-
public boolean AmountLessThan(Money money) {
47+
public boolean LessThan(Money money) {
4848
this.validateDifferentCurrencyForAmountComparators(money);
4949
return this.getAmount() < money.getAmount();
5050
}
5151

52-
public boolean AmountGreaterThan(Money money) {
52+
public boolean GreaterThan(Money money) {
5353
this.validateDifferentCurrencyForAmountComparators(money);
5454
return this.getAmount() > money.getAmount();
5555
}
5656

57-
public boolean AmountEquals(Money money) {
57+
public boolean Equals(Money money) {
5858
this.validateDifferentCurrencyForAmountComparators(money);
5959
return this.getAmount() == money.getAmount();
6060
}

src/test/java/com/wb3tech/kernel/valueobject/MoneyTests.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ public void CompareAmountLessThan() {
9292

9393
var thirteen = Money.Of(13.00, "USD");
9494
var fifteen = Money.Of(15.00, "USD");
95-
var isLessThan = thirteen.AmountLessThan(fifteen);
95+
var isLessThan = thirteen.LessThan(fifteen);
9696

9797
assertTrue(isLessThan);
9898

@@ -103,7 +103,7 @@ public void CompareAmountGreaterThan() {
103103

104104
var thirteen = Money.Of(13.00, "USD");
105105
var fifteen = Money.Of(15.00, "USD");
106-
var isGreaterThan = fifteen.AmountGreaterThan(thirteen);
106+
var isGreaterThan = fifteen.GreaterThan(thirteen);
107107

108108
assertTrue(isGreaterThan);
109109

@@ -114,7 +114,7 @@ public void CompareAmountEquals() {
114114

115115
var fifteenInstanceOne = Money.Of(15.00, "USD");
116116
var fifteenInstanceTwo = Money.Of(15.00, "USD");
117-
var isGreaterThan = fifteenInstanceOne.AmountEquals(fifteenInstanceTwo);
117+
var isGreaterThan = fifteenInstanceOne.Equals(fifteenInstanceTwo);
118118

119119
assertTrue(isGreaterThan);
120120

@@ -166,7 +166,7 @@ public void AmountLessThanThrowArithmeticExceptionForNotSameCurrency() {
166166
var thirteen = Money.Of(13.00, "USD");
167167
var fifteen = Money.Of(15.00, "GBP");
168168

169-
var exception = assertThrows(ArithmeticException.class, () -> thirteen.AmountLessThan(fifteen));
169+
var exception = assertThrows(ArithmeticException.class, () -> thirteen.LessThan(fifteen));
170170
Assertions.assertEquals("Cannot compare of two different currencies.", exception.getMessage());
171171

172172
}
@@ -179,7 +179,7 @@ public void AmountGreaterThanArithmeticExceptionForNotSameCurrency() {
179179
var thirteen = Money.Of(13.00, "USD");
180180
var fifteen = Money.Of(15.00, "GBP");
181181

182-
var exception = assertThrows(ArithmeticException.class, () -> fifteen.AmountGreaterThan(thirteen));
182+
var exception = assertThrows(ArithmeticException.class, () -> fifteen.GreaterThan(thirteen));
183183
Assertions.assertEquals("Cannot compare of two different currencies.", exception.getMessage());
184184

185185
}
@@ -192,7 +192,7 @@ public void AmountEqualsArithmeticExceptionForNotSameCurrency() {
192192
var fifteenInstanceOne = Money.Of(15.00, "USD");
193193
var fifteenInstanceTwo = Money.Of(15.00, "GBP");
194194

195-
var exception = assertThrows(ArithmeticException.class, () -> fifteenInstanceOne.AmountEquals(fifteenInstanceTwo));
195+
var exception = assertThrows(ArithmeticException.class, () -> fifteenInstanceOne.Equals(fifteenInstanceTwo));
196196
Assertions.assertEquals("Cannot compare of two different currencies.", exception.getMessage());
197197

198198
}

0 commit comments

Comments
 (0)