Skip to content

Commit 53c6236

Browse files
committed
remove ambiguous bounding_box method + bug fixes
1 parent bf65227 commit 53c6236

3 files changed

Lines changed: 4 additions & 5 deletions

File tree

src/Interpolation/hyperrectangle.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ Base.isapprox(h1::HyperCube,h2::HyperCube;kwargs...) = isapprox(h1.low_corner,h2
153153
# Utils
154154
######
155155

156-
function bounding_box(els,cube=false)
156+
function HyperRectangle(els,cube=false)
157157
isempty(els) && (error("data cannot be empty") )
158158
lb = first(els) |> coords
159159
ub = first(els) |> coords
@@ -171,7 +171,6 @@ function bounding_box(els,cube=false)
171171
end
172172
return HyperRectangle(lb,ub)
173173
end
174-
HyperRectangle(data,cube=false) = bounding_box(data,cube)
175174

176175
"""
177176
split(rec::AbstractHyperRectangle,[axis]::Int,[place])

src/Mesh/submesh.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Base.view(m::GenericMesh,ent::AbstractEntity) = SubMesh(m,Domain(ent))
2424
Base.view(m::SubMesh::Domain) = view(mesh(m),intersect(Ω,domain(m)))
2525
Base.view(m::SubMesh,ent::AbstractEntity) = view(m,Domain(ent))
2626

27-
parent(m::SubMesh) = m.parent
27+
Base.parent(m::SubMesh) = m.parent
2828
domain(m::SubMesh) = m.domain
2929

3030
# ElementIterator for submesh

src/Trees/clustertree.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ additional `data` field of type `D` can be associated with each node to store
77
node-specific information (it defaults to `D=Nothing`).
88
99
# Fields:
10-
- `_elements::T` : vector containing the sorted elements.
10+
- `_elements::Vector{T}` : vector containing the sorted elements.
1111
- `container::S` : container for the elements in the current node.
1212
- `index_range::UnitRange{Int}` : indices of elements contained in the current node.
1313
- `loc2glob::Vector{Int}` : permutation from the local indexing system to the
@@ -154,7 +154,7 @@ end
154154
Split a `ClusterTree` into two, sorting all elements in the process.
155155
For each resulting child assign `child.parent=parentcluster`.
156156
157-
Passing a `dir` and `pos` arguments splits the `bounding_box` box of `node`
157+
Passing a `dir` and `pos` arguments splits the `container` of `node`
158158
along direction `dir` at position `pos`, then sorts all points into the
159159
resulting left/right nodes.
160160

0 commit comments

Comments
 (0)