Skip to content

Commit ae7468a

Browse files
vivienne-wcalvaris
authored andcommitted
[GStreamer] Fix trimming of track IDs
https://bugs.webkit.org/show_bug.cgi?id=270100 Reviewed by Xabier Rodriguez-Calvar. Use StringView::find() to trim zeroes instead of ::trim(), to not remove trailing zeroes. See previous PR: WebKit/WebKit#23668 * Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp: (WebCore::trimStreamId): fix implementation Canonical link: https://commits.webkit.org/275378@main
1 parent bc510e6 commit ae7468a

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,13 @@ char TrackPrivateBaseGStreamer::prefixForType(TrackType trackType)
5757

5858
static AtomString trimStreamId(StringView streamId)
5959
{
60-
StringView trimmedStreamId = streamId.trim([](auto c) {
61-
return c == '0';
60+
size_t index = streamId.find([](auto c) {
61+
return c != '0';
6262
});
6363

64-
if (trimmedStreamId.isEmpty())
64+
if (index == notFound)
6565
return AtomString::fromLatin1("0");
66-
return AtomString(trimmedStreamId.toString());
66+
return AtomString(streamId.substring(index).toString());
6767
}
6868

6969
AtomString TrackPrivateBaseGStreamer::generateUniquePlaybin2StreamID(TrackType trackType, unsigned index)

0 commit comments

Comments
 (0)