fix(mock-server): handle 404 and return codes for get endpoints

Author: Fahl-Design

data/openapi.yaml

@@ -41,6 +41,16 @@ paths:
               example:
                 id: 1
                 name: Alice
+  /disabled-resource:
+    get:
+      summary: Disabled GET endpoint (API Platform pattern)
+      responses:
+        '404':
+          description: Resource not available via GET
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/Error'
   /users/{id}/tasks:
     post:
       summary: Create a task for a user (async)
@@ -100,3 +110,12 @@ components:
           type: string
         status:
           type: string
+    Error:
+      type: object
+      properties:
+        type:
+          type: string
+        title:
+          type: string
+        status:
+          type: integer

src/Middleware/MockMiddleware/Request/RequestHandler.php

@@ -47,7 +47,7 @@ public function handleValidRequest(
         return $this->responseFaker->mock(
             $openApi,
             $operationAddress,
-            $statusCode ?? $this->getSuccessStatusCodes($openApi, $operationAddress),
+            $statusCode ?? $this->getDefinedStatusCodes($openApi, $operationAddress),
             $acceptedContentTypes,
             $exampleName
         );
@@ -146,12 +146,14 @@ public function handleValidationFailedRequest(
     }
 
     /**
-     * Extract all 2xx status codes defined in the spec for the given operation,
-     * sorted ascending. Falls back to ['200', '201'] if none are found.
+     * Extract status codes defined in the spec for the given operation.
+     *
+     * Priority: 2xx codes first (sorted), then all other defined codes (sorted),
+     * then 'default'. Falls back to ['200', '201'] only if the spec defines no responses at all.
      *
      * @return list<string>
      */
-    private function getSuccessStatusCodes(OpenApi $openApi, OperationAddress $operationAddress): array
+    private function getDefinedStatusCodes(OpenApi $openApi, OperationAddress $operationAddress): array
     {
         try {
             $operation = (new SpecFinder($openApi))
@@ -164,25 +166,34 @@ private function getSuccessStatusCodes(OpenApi $openApi, OperationAddress $opera
             return ['200', '201'];
         }
 
-        $codes = [];
+        $successCodes = [];
+        $otherCodes = [];
+        $hasDefault = false;
+
         foreach (array_keys($operation->responses->getResponses()) as $code) {
             $code = (string) $code;
+
+            if ($code === 'default') {
+                $hasDefault = true;
+                continue;
+            }
+
             if (preg_match('/^2\d{2}$/', $code) === 1) {
-                $codes[] = $code;
+                $successCodes[] = $code;
+            } else {
+                $otherCodes[] = $code;
             }
         }
 
-        sort($codes);
+        sort($successCodes);
+        sort($otherCodes);
 
-        if ($codes === []) {
-            // No 2xx codes defined, check for 'default' response
-            if ($operation->responses->hasResponse('default')) {
-                return ['default'];
-            }
+        $codes = [...$successCodes, ...$otherCodes];
 
-            return ['200', '201'];
+        if ($hasDefault) {
+            $codes[] = 'default';
         }
 
-        return $codes;
+        return $codes !== [] ? $codes : ['200', '201'];
     }
 }

tests/Acceptance/MockServerCest.php

@@ -65,6 +65,13 @@ public function testDeleteReturns204NoContent(AcceptanceTester $acceptanceTester
         $acceptanceTester->seeResponseCodeIs(204);
     }
 
+    public function testGetReturns404WhenOnlyDefinedStatusCode(AcceptanceTester $acceptanceTester): void
+    {
+        $acceptanceTester->sendGet('/disabled-resource');
+        $acceptanceTester->seeResponseCodeIs(404);
+        $acceptanceTester->seeResponseIsJson();
+    }
+
     public function testDisableMockViaHeader(AcceptanceTester $acceptanceTester): void
     {
         // If we explicitly set it to false, it should fall through to Mezzio's root handler