PR 2: Suporte a INSERT e REPLACE sem a palavra-chave INTO

Author: wp-fuse

tests/WP_SQLite_Driver_Tests.php

@@ -21,7 +21,7 @@ public function setUp(): void {
 		$this->engine->query(
 			"CREATE TABLE _options (
 					ID INTEGER PRIMARY KEY AUTO_INCREMENT NOT NULL,
-					option_name TEXT NOT NULL default '',
+					option_name TEXT NOT NULL UNIQUE default '',
 					option_value TEXT NOT NULL default ''
 				);"
 		);
@@ -116,6 +116,29 @@ public function testInsertDateNow() {
 		$this->assertEquals( gmdate( 'Y' ), $results[0]->y );
 	}
 
+	public function testLockingClauses() {
+		$this->assertQuery( "SELECT * FROM _options FOR UPDATE" );
+		$this->assertQuery( "SELECT * FROM _options FOR UPDATE SKIP LOCKED" );
+		$this->assertQuery( "SELECT * FROM _options FOR UPDATE NOWAIT" );
+		$this->assertQuery( "SELECT * FROM _options LOCK IN SHARE MODE" );
+
+		// Complex queries.
+		$this->assertQuery( "SELECT * FROM _options WHERE ID IN (SELECT ID FROM _options FOR UPDATE)" );
+		$this->assertQuery( "SELECT * FROM _options UNION SELECT * FROM _options FOR UPDATE" );
+	}
+
+	public function testInsertWithoutInto() {
+		$this->assertQuery( "INSERT _options (option_name, option_value) VALUES ('test_name', 'test_value')" );
+		$results = $this->engine->query( "SELECT * FROM _options WHERE option_name = 'test_name'" );
+		$this->assertCount( 1, $results );
+		$this->assertEquals( 'test_value', $results[0]->option_value );
+
+		$this->assertQuery( "REPLACE _options (option_name, option_value) VALUES ('test_name', 'replaced_value')" );
+		$results = $this->engine->query( "SELECT * FROM _options WHERE option_name = 'test_name'" );
+		$this->assertCount( 1, $results );
+		$this->assertEquals( 'replaced_value', $results[0]->option_value );
+	}
+
 	public function testUpdateWithLimit() {
 		$this->assertQuery(
 			"INSERT INTO _dates (option_name, option_value) VALUES ('first', '2003-05-27 00:00:45');"

wp-includes/sqlite-ast/class-wp-pdo-mysql-on-sqlite.php

@@ -1830,11 +1830,20 @@ private function execute_select_statement( WP_Parser_Node $node ): void {
 	private function execute_insert_or_replace_statement( WP_Parser_Node $node ): void {
 		$parts                   = array();
 		$on_conflict_update_list = null;
+		$has_into                = false;
 		foreach ( $node->get_children() as $child ) {
 			$is_token = $child instanceof WP_MySQL_Token;
 			$is_node  = $child instanceof WP_Parser_Node;
 
+			if ( $is_token && WP_MySQL_Lexer::INTO_SYMBOL === $child->id ) {
+				$has_into = true;
+			}
+
 			if ( $child instanceof WP_Parser_Node && 'tableRef' === $child->rule_name ) {
+				if ( ! $has_into ) {
+					$parts[]  = 'INTO';
+					$has_into = true;
+				}
 				$database = $this->get_database_name( $child );
 				if ( 'information_schema' === strtolower( $database ) ) {
 					throw $this->new_access_denied_to_information_schema_exception();