Avoid calling strtotime with "0000-00-00 00:00:00" arg

adamziel · web-flow · commit 6c4530ba5a09 · 2023-03-27T10:05:57.000+02:00
Calling strtotime("0000-00-00 00:00:00") in 32-bit environments triggers an "out of integer range" warning: Let's avoid that call for the popular case of "zero" dates. cc @aristath @OllieJones
diff --git a/wp-includes/sqlite/class-wp-sqlite-translator.php b/wp-includes/sqlite/class-wp-sqlite-translator.php
@@ -1574,7 +1574,12 @@ private function preprocess_string_literal( $value ) {
 		 * and stop relying on this MySQL feature,
 		 */
 		if ( 1 === preg_match( '/^(\d{4}-\d{2}-\d{2}) (\d{2}:\d{2}:\d{2})$/', $value, $matches ) ) {
-			if ( false === strtotime( $value ) ) {
+			/*
+			 * Calling strtotime("0000-00-00 00:00:00") in 32-bit environments triggers
+			 * an "out of integer range" warning – let's avoid that call for the popular
+			 * case of "zero" dates.
+			 */
+			if ( $value !== "0000-00-00 00:00:00" && false === strtotime( $value ) ) {
 				$value = '0000-00-00 00:00:00';
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -1574,7 +1574,12 @@ private function preprocess_string_literal( $value ) {`
`1574`	`1574`	`* and stop relying on this MySQL feature,`
`1575`	`1575`	`*/`
`1576`	`1576`	`if ( 1 === preg_match( '/^(\d{4}-\d{2}-\d{2}) (\d{2}:\d{2}:\d{2})$/', $value, $matches ) ) {`
`1577`		`- if ( false === strtotime( $value ) ) {`
	`1577`	`+ /*`
	`1578`	`+ * Calling strtotime("0000-00-00 00:00:00") in 32-bit environments triggers`
	`1579`	`+ * an "out of integer range" warning – let's avoid that call for the popular`
	`1580`	`+ * case of "zero" dates.`
	`1581`	`+ */`
	`1582`	`+ if ( $value !== "0000-00-00 00:00:00" && false === strtotime( $value ) ) {`
`1578`	`1583`	`$value = '0000-00-00 00:00:00';`
`1579`	`1584`	`}`
`1580`	`1585`	`}`