Skip to content

Commit f4a9333

Browse files
JanJakesJanJakes
committed
Simplify and cleanup PHPCS config
1 parent 9f4d56e commit f4a9333

1 file changed

Lines changed: 8 additions & 124 deletions

File tree

‎phpcs.xml.dist‎

Lines changed: 8 additions & 124 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<exclude-pattern>/vendor/*</exclude-pattern>
3434
<exclude-pattern>/node_modules/*</exclude-pattern>
3535
<exclude-pattern>/wordpress/*</exclude-pattern>
36-
<exclude-pattern>/wp-includes/sqlite/class-wp-sqlite-crosscheck-db.php</exclude-pattern>
36+
<exclude-pattern>/packages/sqlite-database-integration/wp-includes/sqlite/class-wp-sqlite-crosscheck-db.php</exclude-pattern>
3737

3838
<!--
3939
#############################################################################
@@ -50,105 +50,6 @@
5050
#############################################################################
5151
-->
5252

53-
<!-- These rules are being set as warnings instead of errors, so we can error check the entire codebase. -->
54-
<rule ref="Generic.Files.OneObjectStructurePerFile.MultipleFound">
55-
<type>warning</type>
56-
<!-- Exclude the unit tests as no warnings are allowed there. Note: these issues should be fixed and the exclude removed! -->
57-
<exclude-pattern>/tests/phpunit/*</exclude-pattern>
58-
</rule>
59-
<rule ref="WordPress.DB.PreparedSQL.InterpolatedNotPrepared">
60-
<type>warning</type>
61-
</rule>
62-
<rule ref="WordPress.DB.PreparedSQL.NotPrepared">
63-
<type>warning</type>
64-
</rule>
65-
<rule ref="WordPress.Files.FileName.InvalidClassFileName">
66-
<type>warning</type>
67-
</rule>
68-
<rule ref="WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase">
69-
<type>warning</type>
70-
</rule>
71-
72-
<rule ref="WordPress.NamingConventions.ValidVariableName">
73-
<properties>
74-
<property name="allowed_custom_properties" type="array">
75-
<!-- From database structure queries. -->
76-
<element value="Collation"/>
77-
<element value="Column_name"/>
78-
<element value="Default"/>
79-
<element value="Extra"/>
80-
<element value="Field"/>
81-
<element value="Index_type"/>
82-
<element value="Key"/>
83-
<element value="Key_name"/>
84-
<element value="Msg_text"/>
85-
<element value="Non_unique"/>
86-
<element value="Null"/>
87-
<element value="Sub_part"/>
88-
<element value="Type"/>
89-
<!-- From plugin/theme data. -->
90-
<element value="authorAndUri"/>
91-
<element value="Name"/>
92-
<element value="Version"/>
93-
<!-- From the result of wp_xmlrpc_server::wp_getPageList(). -->
94-
<element value="dateCreated"/>
95-
96-
<!-- From DOMDocument. -->
97-
<element value="childNodes"/>
98-
<element value="firstChild"/>
99-
<element value="formatOutput"/>
100-
<element value="lastChild"/>
101-
<element value="nodeName"/>
102-
<element value="nodeType"/>
103-
<element value="nodeValue"/>
104-
<element value="parentNode"/>
105-
<element value="preserveWhiteSpace"/>
106-
<element value="textContent"/>
107-
<!-- From PHPMailer. -->
108-
<element value="AltBody"/>
109-
<element value="Body"/>
110-
<element value="CharSet"/>
111-
<element value="ContentType"/>
112-
<element value="Encoding"/>
113-
<element value="Hostname"/>
114-
<element value="mailHeader"/>
115-
<element value="MIMEBody"/>
116-
<element value="MIMEHeader"/>
117-
<element value="Sender"/>
118-
<element value="Subject"/>
119-
<!-- From PHPUnit_Util_Getopt. -->
120-
<element value="longOptions"/>
121-
<!-- From POP3. -->
122-
<element value="ERROR"/>
123-
<!-- From ZipArchive. -->
124-
<element value="numFiles"/>
125-
</property>
126-
</properties>
127-
</rule>
128-
129-
<rule ref="WordPress.PHP.NoSilencedErrors">
130-
<properties>
131-
<property name="customAllowedFunctionsList" type="array">
132-
<element value="ssh2_connect"/>
133-
<element value="ssh2_auth_password"/>
134-
<element value="ssh2_auth_pubkey_file"/>
135-
<element value="ftp_ssl_connect"/>
136-
<element value="ftp_connect"/>
137-
<element value="ftp_get_option"/>
138-
<element value="ftp_set_option"/>
139-
<element value="disk_free_space"/>
140-
<element value="getimagesize"/>
141-
<element value="iptcparse"/>
142-
<element value="exif_read_data"/>
143-
<element value="gzinflate"/>
144-
<element value="gzuncompress"/>
145-
<element value="gzdecode"/>
146-
<element value="imagecreatefromwebp"/>
147-
<element value="imagecreatefromavif"/>
148-
</property>
149-
</properties>
150-
</rule>
151-
15253

15354
<!--
15455
#############################################################################
@@ -160,42 +61,25 @@
16061
-->
16162

16263
<rule ref="WordPress.DB.RestrictedClasses.mysql__PDO">
163-
<exclude-pattern>/wp-includes/sqlite/class-wp-sqlite-translator.php</exclude-pattern>
64+
<exclude-pattern>/packages/sqlite-database-integration/wp-includes/sqlite/class-wp-sqlite-translator.php</exclude-pattern>
65+
<exclude-pattern>/packages/wp-mysql-on-sqlite/src/sqlite/*\.php</exclude-pattern>
66+
<exclude-pattern>/tests/*</exclude-pattern>
67+
</rule>
68+
69+
<rule ref="WordPress.DB.RestrictedClasses">
70+
<exclude-pattern>/tests/*</exclude-pattern>
16471
</rule>
16572

16673
<!-- Assignments in while conditions are a valid method of looping over iterables. -->
16774
<rule ref="Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition">
16875
<exclude-pattern>*</exclude-pattern>
16976
</rule>
17077

171-
<rule ref="WordPress.DB.RestrictedClasses">
172-
<exclude-pattern>/src/wp-includes/sqlite/*\.php</exclude-pattern>
173-
<exclude-pattern>/tests/*</exclude-pattern>
174-
</rule>
175-
17678
<!-- Exclude the unit tests from the file name rules. -->
17779
<rule ref="WordPress.Files.FileName">
17880
<exclude-pattern>/tests/*</exclude-pattern>
17981
</rule>
180-
<rule ref="WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase">
181-
<exclude-pattern>/wp-includes/sqlite/class-wp-sqlite-crosscheck-db.php</exclude-pattern>
182-
</rule>
183-
<rule ref="WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid">
184-
<exclude-pattern>/tests/*</exclude-pattern>
185-
</rule>
186-
<rule ref="WordPress.Files.FileName.NotHyphenatedLowercase">
187-
<exclude-pattern>/tests/*</exclude-pattern>
188-
</rule>
18982
<rule ref="WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase">
19083
<exclude-pattern>/tests/*</exclude-pattern>
19184
</rule>
192-
<rule ref="WordPress.Files.FileName.InvalidClassFileName">
193-
<exclude-pattern>/wp-includes/sqlite/class-wp-sqlite-crosscheck-db.php</exclude-pattern>
194-
</rule>
195-
<rule ref="Universal.Operators.DisallowShortTernary.Found">
196-
<exclude-pattern>/wp-includes/sqlite/class-wp-sqlite-crosscheck-db.php</exclude-pattern>
197-
</rule>
198-
<rule ref="PEAR.NamingConventions.ValidClassName.Invalid">
199-
<exclude-pattern>/wp-includes/sqlite/class-wp-sqlite-crosscheck-db.php</exclude-pattern>
200-
</rule>
20185
</ruleset>

0 commit comments

Comments
 (0)