fix(FileSystemTaskRepository): CanLoadTasksWhoseNameHaveWhitespaces

Author: Xiphereal

Desktop.Tests/Integration/FileSystemTaskRepositoryTest.cs

@@ -4,6 +4,7 @@
 using FluentAssertions;
 using NUnit.Framework;
 using static Desktop.Tests.TestAPI.TaskFactory;
+using static Desktop.Tasks.FileSystemTaskRepository;
 using Task = Desktop.Domain.Task;
 using SystemTask = System.Threading.Tasks.Task;
 
@@ -85,6 +86,26 @@ public async SystemTask CanLoadSeveralPersistedTasks()
         result.Succeeded.Should().BeTrue();
     }
 
+    [Test]
+    [Category("Regression")]
+    public async SystemTask CanLoadTasksWhoseNameHaveWhitespaces()
+    {
+        var taskName = "Task named with whitespaces";
+        PersistTask(taskName);
+        var sut = new FileSystemTaskRepository();
+
+        var result = await sut.All();
+
+        result.Tasks.Should().BeEquivalentTo(
+            [
+                new Task(
+                    name: taskName,
+                    description: string.Empty)
+            ],
+            options => options.ComparingByMembers<Task>().Excluding(x => x.Id));
+        result.Succeeded.Should().BeTrue();
+    }
+
     [Test]
     public async SystemTask CanPersistTasksWhenNoOtherExistedBefore()
     {
@@ -193,7 +214,8 @@ private static void PersistTask(string name, string description = null)
 
         File.AppendAllText(
             PersistedTasksFileName,
-            $"{id} {name} {description ?? string.Empty}{Environment.NewLine}");
+            $"{id}{LineElementSeparator}{name}{LineElementSeparator}{description ?? string.Empty}" +
+            $"{Environment.NewLine}");
     }
 
     [TearDown]

Desktop/TODO.md

@@ -1,5 +1,4 @@
-- fix(file system repository): tasks names with whitespaces are trimmed so that only the first word is displayed
-- feat: Flow metrics (MonteCSharp integration)
+- feat: Flow metrics (MonteCSharp integration)
 - test: ensure coverage for the sln and review testing strategy
 - feat: Tasks may have other child Tasks
 - feat: show tasks in as project tree

Desktop/Tasks/FileSystemTaskRepository.cs

@@ -7,6 +7,7 @@ namespace Desktop.Tasks;
 public class FileSystemTaskRepository : ITaskRepository
 {
     private const string PersistedTasksFileName = "Tasks.txt";
+    public const string LineElementSeparator = "|";
 
     public Task<ResultWithValue> All()
     {
@@ -23,19 +24,16 @@ public Task<ResultWithValue> All()
 
     private static Task ToTask(string line)
     {
+        var lineElements = line.Split(LineElementSeparator);
+
         return new Task(
-            id: Guid.Parse(SplitBySpaces(line).ElementAt(0)),
-            name: SplitBySpaces(line).ElementAt(1),
-            description: SplitBySpaces(line).Length > 1
-                ? SplitBySpaces(line).Last()
+            id: Guid.Parse(lineElements.ElementAt(0)),
+            name: lineElements.ElementAt(1),
+            description: lineElements.Length > 1
+                ? lineElements.Last()
                 : string.Empty);
     }
 
-    private static string[] SplitBySpaces(string line)
-    {
-        return line.Split(' ');
-    }
-
     public async Task<ResultWithoutValue> Save(Task task)
     {
         var existingTasks = await All();
@@ -44,7 +42,8 @@ public async Task<ResultWithoutValue> Save(Task task)
 
         await File.AppendAllTextAsync(
             PersistedTasksFileName,
-            $"{task.Id} {task.Name} {task.Description}{Environment.NewLine}");
+            $"{task.Id}{LineElementSeparator}{task.Name}{LineElementSeparator}{task.Description}" +
+            $"{Environment.NewLine}");
 
         return ResultWithoutValue.Success();
     }