refactor: move Task deletion from code behind to view model

Author: Xiphereal

Desktop/MainWindow.xaml.cs

@@ -24,9 +24,7 @@ public MainWindow(
 
     private void NavigateToTaskList()
     {
-        var tasksList = new TasksList(
-            taskRepository,
-            taskListViewModel);
+        var tasksList = new TasksList(taskListViewModel);
         Content.Content = tasksList;
     }
 

Desktop/Project/TaskListViewModel.cs

@@ -30,10 +30,18 @@ public TaskListViewModel(
 
             Tasks.Add(taskCreationViewModel.CreatedTask);
         });
+
+        Delete = new RelayCommand<Task>(taskToRemove =>
+        {
+            Tasks.Remove(taskToRemove!);
+            taskRepository.Delete(taskToRemove!);
+        });
     }
 
     public ICommand Add { get; }
 
+    public ICommand Delete { get; }
+
     public void PopulateTasks()
     {
         // TODO: load this async and deferred from the ctor.

Desktop/Project/TasksList.xaml

@@ -1,4 +1,5 @@
 <UserControl x:Class="Desktop.Project.TasksList"
+             x:Name="Root"
              xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
              xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
              xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
@@ -22,7 +23,9 @@
                     <DataTemplate DataType="{x:Type domain:Task}">
                         <StackPanel Orientation="Horizontal">
                             <TextBlock Text="{Binding Name}" />
-                            <Button Content="Delete" Click="Delete" />
+                            <Button Content="Delete"
+                                    Command="{Binding DataContext.Delete, ElementName=Root}"
+                                    CommandParameter="{Binding}" />
                         </StackPanel>
                     </DataTemplate>
                 </ListBox.ItemTemplate>

Desktop/Project/TasksList.xaml.cs

@@ -1,5 +1,4 @@
-using System.Windows;
-using System.Windows.Controls;
+using System.Windows.Controls;
 using System.Windows.Input;
 using Desktop.Tasks;
 using Task = Desktop.Domain.Task;
@@ -8,15 +7,8 @@ namespace Desktop.Project;
 
 public partial class TasksList : UserControl
 {
-    private readonly ITaskRepository taskRepository;
-    private readonly TaskListViewModel viewModel;
-
-    public TasksList(
-        ITaskRepository taskRepository,
-        TaskListViewModel viewModel)
+    public TasksList(TaskListViewModel viewModel)
     {
-        this.taskRepository = taskRepository;
-        this.viewModel = viewModel;
         DataContext = viewModel;
 
         InitializeComponent();
@@ -35,15 +27,4 @@ private void Edit(object sender, MouseButtonEventArgs e)
         var window = new TaskEditing(task);
         window.ShowDialog();
     }
-
-    private void Delete(object sender, RoutedEventArgs e)
-    {
-        if (sender is not Button button)
-            return;
-
-        var toRemove = button.DataContext as Task;
-
-        viewModel.Tasks.Remove(toRemove!);
-        taskRepository.Delete(toRemove!);
-    }
 }

Desktop/Tasks/TaskCreationViewModel.cs

@@ -20,5 +20,6 @@ public TaskCreationViewModel(ITaskRepository taskRepository)
     }
 
     public IRelayCommand SaveTask { get; }
+
     public Task? CreatedTask { get; private set; }
 }