feat: TaskCreation_FailsForOne_NotifiesOnceAndAllowsSavingItToTheRestOfRepositories

Author: Xiphereal

Desktop.Tests/UnitTests/TaskCreationViewModelTests.cs

@@ -1,4 +1,5 @@
-using Desktop.Common;
+using System.Threading.Tasks;
+using Desktop.Common;
 using Desktop.Tasks;
 using Desktop.Tests.TestAPI;
 using FluentAssertions;
@@ -10,10 +11,15 @@ namespace Desktop.Tests.UnitTests;
 
 public class TaskCreationViewModelTests
 {
+    private const string TaskCreationFailedMessage =
+        "Task creation has failed due to " +
+        "an internal error. The Task won't be created. " +
+        "Please, try again later.";
+
     [Test]
     public void TaskCreation_Fails_MessageNotifiesUserAndTasksIsNotAddedToTheList()
     {
-        var repository = new InMemoryTaskRepository([AnyDesktopTask()]);
+        var repository = new InMemoryTaskRepository([]);
         repository.FailAlways();
         var messageNotifierMock = new Mock<IMessageNotifier>();
         var sut = new TaskCreationViewModel(
@@ -24,9 +30,46 @@ public void TaskCreation_Fails_MessageNotifiesUserAndTasksIsNotAddedToTheList()
         sut.SaveTask.Execute((closeable.Object, "Any name", "Any description"));
 
         messageNotifierMock.Verify(x => x.Notify(
-            "Task creation has failed due to " +
-            "an internal error. The Task won't be created. " +
-            "Please, try again later."));
+            TaskCreationFailedMessage));
         sut.CreatedTask.Should().BeNull();
     }
+
+    [Test]
+    public async Task
+        TaskCreation_FailsForOne_NotifiesOnceAndAllowsSavingItToTheRestOfRepositories()
+    {
+        // Arrange.
+        var aRepository = new InMemoryTaskRepository([]);
+        aRepository.FailAlways();
+        var anotherRepository = new InMemoryTaskRepository([]);
+
+        var messageNotifierMock = new Mock<IMessageNotifier>();
+        var sut = new TaskCreationViewModel(
+            messageNotifierMock.Object,
+            [aRepository, anotherRepository]);
+        var closeable = new Mock<ICloseable>();
+
+        // Act.
+        var taskName = "Any name";
+        var taskDescription = "Any description";
+        sut.SaveTask.Execute((closeable.Object, taskName, taskDescription));
+
+        // Assert.
+        messageNotifierMock.Verify(
+            x => x.Notify(TaskCreationFailedMessage),
+            Times.Once);
+        var createdTask = DesktopTask(taskName, taskDescription);
+        sut.CreatedTask.Should().BeEquivalentTo(
+            createdTask,
+            options => options
+                .ComparingByMembers<Domain.Task>()
+                .Excluding(x => x.Id));
+
+        var result = await anotherRepository.All();
+        result.Tasks.Should().ContainEquivalentOf(
+            createdTask,
+            options => options
+                .ComparingByMembers<Domain.Task>()
+                .Excluding(x => x.Id));
+    }
 }

Desktop/Tasks/TaskCreationViewModel.cs

@@ -17,23 +17,23 @@ public TaskCreationViewModel(
 
                 CreatedTask = new Task(taskName, taskDescription);
 
+                var anySucceeded = false;
                 foreach (var repository in taskRepositories)
                 {
                     var creationResult = await repository.Save(CreatedTask);
 
-                    if (!creationResult.Succeeded)
-                    {
+                    if (creationResult.Succeeded)
+                        anySucceeded = true;
+                    else
                         messageNotifier.Notify(
                             "Task creation has failed due to " +
                             "an internal error. The Task won't be created. " +
                             "Please, try again later.");
-
-                        CreatedTask = null;
-
-                        break;
-                    }
                 }
 
+                if (!anySucceeded)
+                    CreatedTask = null;
+
                 closeable!.Close();
             });
     }