Skip to content

Commit 6d54d45

Browse files
committed
using same param name during inheritance
1 parent b4ae5ca commit 6d54d45

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

class/Files/Classes/ClassHandlerFiles.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -147,10 +147,10 @@ private function getClassCreate()
147147
*/
148148
private function getClassGet()
149149
{
150-
$ret = $this->pc->getPhpCodeCommentMultiLine(['retrieve a' => 'field', '' => '', '@param int' => '$i field id', '@param null' => 'fields', '@return \XoopsObject|null reference to the' => '{@link Get} object'], "\t");
151-
$cClhg = $this->getSimpleString('return parent::get($i, $fields);', "\t\t");
150+
$ret = $this->pc->getPhpCodeCommentMultiLine(['retrieve a' => 'field', '' => '', '@param int' => '$id field id', '@param null' => 'fields', '@return \XoopsObject|null reference to the' => '{@link Get} object'], "\t");
151+
$cClhg = $this->getSimpleString('return parent::get($id, $fields);', "\t\t");
152152

153-
$ret .= $this->pc->getPhpCodeFunction('get', '$i = null, $fields = null', $cClhg, 'public ', false, "\t");
153+
$ret .= $this->pc->getPhpCodeFunction('get', '$id = null, $fields = null', $cClhg, 'public ', false, "\t");
154154

155155
return $ret;
156156
}

docs/changelog.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
- fix bug in type cast (liomj/goffy)
2323
- removed unnecessary sprintf (goffy)
2424
- replace ternary expression by condition (goffy)
25+
- using same param name during inheritance (goffy)
2526

2627
<h5>3.5.1 Beta 1 [NOT RELEASED]</h5> Dev: XOOPS 2.5.11, PHP 7.4.25, PHP 8.0.12, PHP 8.1.0 Beta 4
2728
- semantic versioning (mamba)

0 commit comments

Comments
 (0)