- fixed bug in creation of header.php

Author: ggoffy

class/Files/User/UserHeader.php

@@ -97,7 +97,6 @@ public function write($module, $table, $tables, $filename)
     private function getUserHeader($moduleDirname)
     {
         $stuModuleDirname = \mb_strtoupper($moduleDirname);
-        $table            = $this->getTable();
         $tables           = $this->getTables();
         $language         = $this->getLanguage($moduleDirname, 'MA');
 
@@ -106,16 +105,24 @@ private function getUserHeader($moduleDirname)
         $ret .= $this->xc->getXcEqualsOperator('$moduleDirName', '\basename(__DIR__)');
         $ret .= $this->uxc->getUserBreadcrumbsHeaderFile($moduleDirname, $language);
         $ret .= $this->xc->getXcHelperGetInstance($moduleDirname);
+        $permissions = 0;
+        $ratings     = 0;
         if (\is_array($tables)) {
             foreach (\array_keys($tables) as $i) {
                 $tableName = $tables[$i]->getVar('table_name');
                 $ret       .= $this->xc->getXcHandlerLine($tableName);
+                if (1 == $tables[$i]->getVar('table_permissions')) {
+                    $permissions = 1;
+                }
+                if (1 == $tables[$i]->getVar('table_rate')) {
+                    $ratings = 1;
+                }
             }
         }
-        if (1 == $table->getVar('table_permissions')) {
+        if (1 == $permissions) {
             $ret .= $this->xc->getXcHandlerLine('permissions');
         }
-        if (1 == $table->getVar('table_rate')) {
+        if (1 == $ratings) {
             $ret .= $this->xc->getXcHandlerLine('ratings');
         }
         $ret .= $this->pc->getPhpCodeCommentLine();

docs/changelog.txt

@@ -15,6 +15,7 @@
 - added check for sql creation (goffy)
 - delete fields if table is deleted (goffy)
 - delete fields, tables, morefiles when deleting module (goffy)
+- fixed bug in creation of header.php (goffy)
 
 <h5>3.04 Alpha 1   [2020-06-12]</h5>  Dev: XOOPS 2.5.11, PHP 7.4.5
 <hr>