Merge pull request #3 from mambax7/master

Adding GPL Label

Author: mambax7

.gitattributes

@@ -0,0 +1,17 @@
+# Auto detect text files and perform LF normalization
+* text=auto
+
+# Custom for Visual Studio
+*.cs     diff=csharp
+
+# Standard to msysgit
+*.doc	 diff=astextplain
+*.DOC	 diff=astextplain
+*.docx diff=astextplain
+*.DOCX diff=astextplain
+*.dot  diff=astextplain
+*.DOT  diff=astextplain
+*.pdf  diff=astextplain
+*.PDF	 diff=astextplain
+*.rtf	 diff=astextplain
+*.RTF	 diff=astextplain

.gitignore

@@ -0,0 +1,5 @@
+# no backup files, editor temp
+*~
+\#*
+*.bak
+.idea/

.scrutinizer.yml

@@ -0,0 +1,50 @@
+checks:
+    php:
+        code_rating: true
+        variable_existence: true
+        useless_calls: true
+        use_statement_alias_conflict: true
+        unused_variables: true
+        unused_properties: true
+        unused_parameters: true
+        unused_methods: true
+        unreachable_code: true
+        sql_injection_vulnerabilities: true
+        security_vulnerabilities: true
+        precedence_mistakes: true
+        precedence_in_conditions: true
+        parameter_non_unique: true
+        no_property_on_interface: true
+        no_non_implemented_abstract_methods: true
+        deprecated_code_usage: true
+        closure_use_not_conflicting: true
+        closure_use_modifiable: true
+        avoid_useless_overridden_methods: true
+        avoid_conflicting_incrementers: true
+        assignment_of_null_return: true
+        verify_property_names: true
+        verify_argument_usable_as_reference: true
+        verify_access_scope_valid: true
+        use_self_instead_of_fqcn: true
+        too_many_arguments: true
+        single_namespace_per_use: true
+        return_doc_comment_if_not_inferrable: true
+        return_doc_comments: true
+        require_scope_for_methods: true
+        require_scope_for_properties: true
+        require_php_tag_first: true
+        require_braces_around_control_structures: true
+        psr2_control_structure_declaration: true
+        psr2_switch_declaration: true
+        psr2_class_declaration: true
+        no_eval: true
+        no_else_if_statements: true
+        avoid_corrupting_byteorder_marks: true
+        argument_type_checks: true
+        php5_style_constructor: true
+        parameter_doc_comments: true
+        no_duplicate_arguments: true
+        missing_arguments: true
+        instanceof_class_exists: true
+        foreach_traversable: true
+        no_unnecessary_function_call_in_for_loop: true

.travis.yml

@@ -0,0 +1,8 @@
+language: php
+script:
+  - phpunit
+php:
+  - 5.3
+  - 5.4
+  - 5.5
+  - 5.6

README.md

@@ -1,4 +1,4 @@
-tag
-===
+#Tag
+[![Software License](https://img.shields.io/badge/license-GPL-brightgreen.svg?style=flat)](LICENSE) 
 
 The Tag module is designed for site-wide tag management, handling tag input, display and stats for each module that enables tag plugin.

tag/class/blockform.php

@@ -55,6 +55,7 @@ function render()
         }
         $ret .= "</div>\n";
         $ret .= $this->renderValidationJS(true);
+
         return $ret;
     }
 }

tag/class/formvalidatedinput.php

@@ -49,11 +49,11 @@ class TagFormValidatedInput extends XoopsFormText
     /**
      * Constructor
      *
-     * @param string $caption Caption
-     * @param string $name "name" attribute
-     * @param int $size Size
-     * @param int $maxlength Maximum length of text
-     * @param string $value Initial text
+     * @param string $caption   Caption
+     * @param string $name      "name" attribute
+     * @param int    $size      Size
+     * @param int    $maxlength Maximum length of text
+     * @param string $value     Initial text
      */
     function __construct($caption, $name, $size, $maxlength, $value = '', $type='text')
     {
@@ -138,6 +138,7 @@ public function render()
     {
         $myClasses = $this->getClass();
         $classes = ($myClasses) ? " class='{$myClasses}'" : "";
+
         return "<input type='" . $this->_type . "' name='" . $this->getName() . "' title='" . $this->getTitle() . "' id='" . $this->getName() . "' size='" . $this->getSize() . "' maxlength='" . $this->getMaxlength() . "' value='" . $this->getValue() . "'" . $classes . $this->getExtra() . " />";
     }
 }

tag/class/tag.php

@@ -89,10 +89,10 @@ public function TagTagHandler(&$db)
      * Get tags linked to an item
      *
      * @access public
-     * @param  int     $itemid item ID
-     * @param  int     $modid  module ID, optional
-     * @param  int     $catid  id of corresponding category, optional
-     * @return array   associative array of tags (id, term)
+     * @param  int   $itemid item ID
+     * @param  int   $modid  module ID, optional
+     * @param  int   $catid  id of corresponding category, optional
+     * @return array associative array of tags (id, term)
      */
     public function getByItem($itemid, $modid = 0, $catid = 0)
     {
@@ -123,10 +123,10 @@ public function getByItem($itemid, $modid = 0, $catid = 0)
      * Update tags linked to an item
      *
      * @access public
-     * @param  array|string array of $tags or a single tag
-     * @param  int          $itemid item ID
-     * @param  int          $modid  module ID or module dirname, optional
-     * @param  int          $catid  id of corresponding category, optional
+     * @param  array|string array of $tags   or a single tag
+     * @param  int                   $itemid item ID
+     * @param  int                   $modid  module ID or module dirname, optional
+     * @param  int                   $catid  id of corresponding category, optional
      * @return bool
      */
     public function updateByItem($tags, $itemid, $modid = "", $catid = 0)
@@ -319,10 +319,10 @@ public function update_stats($tag_id, $modid = 0, $catid = 0)
      * Get tags with item count
      *
      * @access         public
-     * @param  object  $criteria {@link Criteria}
-     * @param  boolean $fromStats fetch from tag-stats table
+     * @param object  $criteria  {@link Criteria}
+     * @param boolean $fromStats fetch from tag-stats table
      *
-     * @return array   associative array of tags (id, term, count)
+     * @return array associative array of tags (id, term, count)
      */
     public function &getByLimit($criteria = null, $fromStats = true)
     {
@@ -390,7 +390,7 @@ public function &getByLimit($criteria = null, $fromStats = true)
      * Get count of tags
      *
      * @access public
-     * @param  object $criteria {@link Criteria)
+     * @param object $criteria {@link Criteria)
      *
      * @return integer count
      */

tag/header.php

@@ -20,7 +20,6 @@
  * @version         $Id: header.php 12898 2014-12-08 22:05:21Z zyspec $
  */
 
-
 include_once '../../mainfile.php';
 include __DIR__ . "/include/vars.php";
 include_once __DIR__ . "/include/functions.php";

tag/include/action.module.php

@@ -52,6 +52,7 @@ function xoops_module_pre_install_tag(&$module)
     }
     if (!$success) {
         $module->setErrors("This module requires XOOPS {$requiredVer}+ ({$currentVer} installed)");
+
         return false;
     }
 
@@ -62,6 +63,7 @@ function xoops_module_pre_install_tag(&$module)
     $reqVer = $module->getInfo('min_php');
     if ($verNum < $reqVer) {
         $module->setErrors( "The module requires PHP {$reqVer}+ ({$verNum} installed)");
+
         return false;
     }