Assignment in condition

mambax7 · mambax7 · commit e6799a5a5826 · 2019-02-11T20:25:28.000-05:00
diff --git a/blocks/block.php b/blocks/block.php
@@ -157,7 +157,7 @@ function tag_block_cloud_show($options, $dirname = '', $catid = 0)
     if (!empty($modid)) {
         /** @var \XoopsModuleHandler $moduleHandler */
         $moduleHandler = xoops_getHandler('module');
-        if ($module_obj = $moduleHandler->get($modid)) {
+        if (false !== ($module_obj = $moduleHandler->get($modid))) {
             $block['tag_dirname'] = $module_obj->getVar('dirname');
         }
     }
@@ -309,7 +309,7 @@ function tag_block_top_show($options, $dirname = '', $catid = 0)
     if (!empty($modid)) {
         /** @var \XoopsModuleHandler $moduleHandler */
         $moduleHandler = xoops_getHandler('module');
-        if ($module_obj = $moduleHandler->get($modid)) {
+        if (false !== ($module_obj = $moduleHandler->get($modid))) {
             $block['tag_dirname'] = $module_obj->getVar('dirname');
         }
     }
@@ -447,7 +447,7 @@ function tag_block_cumulus_show(array $options, $dirname = '', $catid = 0)
     if (!empty($modid)) {
         /** @var \XoopsModuleHandler $moduleHandler */
         $moduleHandler = xoops_getHandler('module');
-        if ($module_obj = $moduleHandler->get($modid)) {
+        if (false !== ($module_obj = $moduleHandler->get($modid))) {
             $block['tag_dirname'] = $module_obj->getVar('dirname');
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ function tag_block_cloud_show($options, $dirname = '', $catid = 0)`
`157`	`157`	`if (!empty($modid)) {`
`158`	`158`	`/** @var \XoopsModuleHandler $moduleHandler */`
`159`	`159`	`$moduleHandler = xoops_getHandler('module');`
`160`		`- if ($module_obj = $moduleHandler->get($modid)) {`
	`160`	`+ if (false !== ($module_obj = $moduleHandler->get($modid))) {`
`161`	`161`	`$block['tag_dirname'] = $module_obj->getVar('dirname');`
`162`	`162`	`}`
`163`	`163`	`}`
`@@ -309,7 +309,7 @@ function tag_block_top_show($options, $dirname = '', $catid = 0)`
`309`	`309`	`if (!empty($modid)) {`
`310`	`310`	`/** @var \XoopsModuleHandler $moduleHandler */`
`311`	`311`	`$moduleHandler = xoops_getHandler('module');`
`312`		`- if ($module_obj = $moduleHandler->get($modid)) {`
	`312`	`+ if (false !== ($module_obj = $moduleHandler->get($modid))) {`
`313`	`313`	`$block['tag_dirname'] = $module_obj->getVar('dirname');`
`314`	`314`	`}`
`315`	`315`	`}`
`@@ -447,7 +447,7 @@ function tag_block_cumulus_show(array $options, $dirname = '', $catid = 0)`
`447`	`447`	`if (!empty($modid)) {`
`448`	`448`	`/** @var \XoopsModuleHandler $moduleHandler */`
`449`	`449`	`$moduleHandler = xoops_getHandler('module');`
`450`		`- if ($module_obj = $moduleHandler->get($modid)) {`
	`450`	`+ if (false !== ($module_obj = $moduleHandler->get($modid))) {`
`451`	`451`	`$block['tag_dirname'] = $module_obj->getVar('dirname');`
`452`	`452`	`}`
`453`	`453`	`}`