Scrutinizer

Author: mambax7

class/Blanguage.php

@@ -32,6 +32,7 @@ class Blanguage extends \XoopsObject
 {
     public $isBase = false;
     public $db;
+    public $table;
 
     /**
      * Blanguage constructor.

class/Common/FilesManagement.php

@@ -61,16 +61,18 @@ public static function recurseCopy($src, $dst)
         if (!@mkdir($dst) && !is_dir($dst)) {
             throw new \RuntimeException('The directory ' . $dst . ' could not be created.');
         }
-        while (false !== ($file = readdir($dir))) {
-            if (('.' !== $file) && ('..' !== $file)) {
-                if (is_dir($src . '/' . $file)) {
-                    self::recurseCopy($src . '/' . $file, $dst . '/' . $file);
-                } else {
-                    copy($src . '/' . $file, $dst . '/' . $file);
+        if (false !== $dir) {
+            while (false !== ($file = readdir($dir))) {
+                if (('.' !== $file) && ('..' !== $file)) {
+                    if (is_dir($src . '/' . $file)) {
+                        self::recurseCopy($src . '/' . $file, $dst . '/' . $file);
+                    } else {
+                        copy($src . '/' . $file, $dst . '/' . $file);
+                    }
                 }
             }
+            closedir($dir);
         }
-        closedir($dir);
     }
 
     /**
@@ -95,7 +97,8 @@ public static function deleteDirectory($src)
         $dirInfo = new \SplFileInfo($src);
         // validate is a directory
         if ($dirInfo->isDir()) {
-            $fileList = array_diff(scandir($src, SCANDIR_SORT_NONE), ['..', '.']);
+            $dirScan = scandir($src, SCANDIR_SORT_NONE);
+            $fileList = array_diff($dirScan, ['..', '.']);
             foreach ($fileList as $k => $v) {
                 $fileInfo = new \SplFileInfo("{$src}/{$v}");
                 if ($fileInfo->isDir()) {

class/LanguageHandler.php

@@ -41,7 +41,7 @@ public function loadConfig()
      * @param int  $id
      * @param bool $isBase
      *
-     * @return Blanguage|null|Language
+     * @return Blanguage|Language|null
      */
     public function get($id, $isBase = true)
     {
@@ -78,7 +78,7 @@ public function get($id, $isBase = true)
      * @param string $name
      * @param bool $isBase
      *
-     * @return Xlanguage\Blanguage|null|Xlanguage\Language
+     * @return Xlanguage\Blanguage|Xlanguage\Language|null
      */
     public function getByName($name, $isBase=false)
     {
@@ -201,8 +201,8 @@ public function create($isNew = true, $isBase = true)
     }
 
     /**
-     * @param \XoopsObject $object
-     * @return bool
+     * @param Blanguage|Language $object
+     * @return bool|string
      * @internal param object $lang
      */
     public function insert(\XoopsObject $object)//insert(&$lang)

class/Utility.php

@@ -203,6 +203,7 @@ public static function cleanMultiLang($text)
     {
         global $xoopsConfig;
         global $xlanguage_langs;
+        $patterns = [];
         if (!isset($xlanguage_langs)) {
             $xlanguage_langs = [];
             /** @var \XoopsModules\Xlanguage\Helper $helper */
@@ -281,7 +282,7 @@ public static function escapeBracketMultiLang($matches)
     }
 
     /**
-     * @param null $options
+     * @param null|array $options
      * @return bool
      */
     public static function showSelectedLanguage($options = null)

include/oninstall.php

@@ -69,6 +69,7 @@ function xoops_module_install_xlanguage(\XoopsModule $module)
     global $xoopsModule;
     $moduleId         = $xoopsModule->getVar('mid');
     // $moduleId2        = $helper->getModule()->mid();
+    /** @var \XoopsGroupPermHandler $grouppermHandler */
     $grouppermHandler = xoops_getHandler('groupperm');
     // access rights ------------------------------------------
     $grouppermHandler->addRight($moduleDirName . '_approve', 1, XOOPS_GROUP_ADMIN, $moduleId);

include/onupdate.php

@@ -59,7 +59,7 @@ function xoops_module_pre_update_xlanguage(\XoopsModule $module)
 /**
  * Performs tasks required during update of the module
  * @param \XoopsModule $module {@link XoopsModule}
- * @param null        $previousVersion
+ * @param null|string|int        $previousVersion
  *
  * @return bool true if update successful, false if not
  */