chore: make more arena functions public (#27)

Author: YoEight

src/arena.rs

@@ -34,6 +34,11 @@ impl StringArena {
         }
     }
 
+    /// If that value has already been interned, it returns the string pointer in the arena.
+    pub fn str_ref(&self, value: &str) -> Option<StrRef> {
+        self.cache.get(&self.hasher.hash_one(value)).copied()
+    }
+
     /// Interns a string using case-insensitive hashing.
     ///
     /// Two strings that differ only in ASCII case will resolve to the same [`StrRef`].
@@ -345,6 +350,11 @@ impl Arena {
         self.strings.get(key)
     }
 
+    /// If that value has already been interned, it returns the string pointer in the arena.
+    pub fn str_ref(&self, key: &str) -> Option<StrRef> {
+        self.strings.str_ref(key)
+    }
+
     /// Retrieves the expression node associated with the given [`ExprRef`].
     pub fn get_expr(&self, key: ExprRef) -> Expr {
         self.exprs.get(key)

src/ast.rs

@@ -270,7 +270,7 @@ pub enum SourceKind<A> {
 /// In `ORDER BY e.timestamp DESC`, this would be represented as:
 /// - `expr`: expression for `e.timestamp`
 /// - `order`: `Order::Desc`
-#[derive(Debug, Clone, Serialize)]
+#[derive(Debug, Clone, Copy, Serialize)]
 pub struct OrderBy {
     /// Expression to sort by
     pub expr: ExprRef,

src/lib.rs

@@ -16,7 +16,7 @@ mod typing;
 use crate::arena::Arena;
 use crate::lexer::tokenize;
 use crate::prelude::{
-    Analysis, AnalysisOptions, FunArgs, Typed, display_type, name_to_type, parse,
+    Analysis, AnalysisOptions, FunArgs, Scope, Typed, display_type, name_to_type, parse,
 };
 use crate::token::Token;
 pub use ast::*;
@@ -550,8 +550,8 @@ impl Session {
     /// - `"date"` → [`Type::Date`]
     /// - `"time"` → [`Type::Time`]
     /// - `"datetime"` → [`Type::DateTime`]
-    pub fn get_type_from_name(&mut self, name: &str) -> Option<Type> {
-        let str_ref = self.arena.strings.alloc(name);
+    pub fn get_type_from_name(&self, name: &str) -> Option<Type> {
+        let str_ref = self.arena.strings.str_ref(name)?;
         name_to_type(&self.arena, &self.options, str_ref)
     }
 
@@ -560,8 +560,8 @@ impl Session {
     /// Function types display optional parameters with a `?` suffix. For example,
     /// a function with signature `(boolean, number?) -> string` accepts 1 or 2 arguments.
     /// Aggregate functions use `=>` instead of `->` in their signature.
-    pub fn display_type(&self, tpe: &Type) -> String {
-        display_type(&self.arena, *tpe)
+    pub fn display_type(&self, tpe: Type) -> String {
+        display_type(&self.arena, tpe)
     }
 
     /// Creates an [`Analysis`] instance for fine-grained control over static analysis.
@@ -581,4 +581,9 @@ impl Session {
     pub fn arena_mut(&mut self) -> &mut Arena {
         &mut self.arena
     }
+
+    /// Returns the global [`Scope`]
+    pub fn global_scope(&self) -> &Scope {
+        &self.options.default_scope
+    }
 }