Improve typing

Author: dainnilsson

.pre-commit-config.yaml

@@ -1,6 +1,6 @@
 repos:
 - repo: https://github.com/astral-sh/ruff-pre-commit
-  rev: v0.15.6
+  rev: v0.15.7
   hooks:
   # Run the linter
   - id: ruff-check

fido2/attestation/base.py

@@ -31,7 +31,7 @@
 from dataclasses import dataclass
 from enum import IntEnum, unique
 from functools import wraps
-from typing import Any, Mapping, Sequence
+from typing import Any, Mapping, Sequence, cast
 
 from cryptography import x509
 from cryptography.exceptions import InvalidSignature as _InvalidSignature
@@ -197,7 +197,7 @@ def _validate_cert_common(cert):
 
 def _default_attestations():
     return [
-        cls()  # type: ignore
+        cast(type[Any], cls)()
         for cls in Attestation.__subclasses__()
         if getattr(cls, "FORMAT", "none") != "none"
     ]

fido2/client/win_api.py

@@ -849,7 +849,7 @@ def __del__(self):
 
 
 HRESULT = ctypes.HRESULT  # type: ignore
-WEBAUTHN = windll.webauthn  # type: ignore
+WEBAUTHN = windll.webauthn
 WEBAUTHN_API_VERSION = WEBAUTHN.WebAuthNGetApiVersionNumber()
 
 WEBAUTHN.WebAuthNIsUserVerifyingPlatformAuthenticatorAvailable.argtypes = [

fido2/ctap.py

@@ -30,7 +30,7 @@
 import abc
 from enum import IntEnum, unique
 from threading import Event
-from typing import Callable, Iterator
+from typing import Callable, Iterator, cast
 
 
 @unique
@@ -177,5 +177,5 @@ def __init__(self, code: int):
         try:
             self.code = CtapError.ERR(code)
         except ValueError:
-            self.code = CtapError.UNKNOWN_ERR(code)  # type: ignore
+            self.code = cast(CtapError.ERR, CtapError.UNKNOWN_ERR(code))
         super().__init__(f"CTAP error: {self.code}")

fido2/ctap2/base.py

@@ -62,7 +62,7 @@ def args(*params) -> dict[int, Any]:
 class _CborDataObject(_DataClassMapping[int]):
     @classmethod
     def _get_field_key(cls, field: Field) -> int:
-        return fields(cls).index(field) + 1  # type: ignore
+        return fields(cls).index(field) + 1
 
 
 @dataclass(eq=False, frozen=True)

fido2/hid/openbsd.py

@@ -102,7 +102,7 @@ def get_descriptor(path):
     dev_info = UsbDeviceInfo()
 
     try:
-        fcntl.ioctl(f, USB_GET_DEVICEINFO, dev_info)  # type: ignore
+        fcntl.ioctl(f, USB_GET_DEVICEINFO, dev_info)
     finally:
         os.close(f)
 

fido2/webauthn.py

@@ -345,7 +345,9 @@ class _StringEnumMeta(EnumMeta):
     def _get_value(cls, value):
         return None
 
-    def __call__(cls, value, *args, **kwargs):  # type: ignore
+    def __call__(  # pyright: ignore[reportIncompatibleMethodOverride]
+        cls, value, *args, **kwargs
+    ):
         try:
             return super().__call__(value, *args, **kwargs)
         except ValueError:

pyproject.toml

@@ -63,3 +63,13 @@ venvPath = "."
 venv = ".venv"
 exclude = ["tests/", "docs/", "examples/"]
 reportPrivateImportUsage = false
+
+[tool.ty.src]
+exclude = ["docs"]
+
+[[tool.ty.overrides]]
+include = ["tests/**", "**/test_*.py"]
+
+[tool.ty.overrides.rules]
+unresolved-attribute = "ignore"
+invalid-argument-type = "ignore"