Refactor tests in MaybeExtensions to improve clarity and add async handling for TapIfSome and TapIfNone methods

Author: ZeidLab

ToolBox.Test.Units/Options/MaybeExtensionsBindTests.cs

@@ -1,6 +1,5 @@
 using FluentAssertions;
 using ZeidLab.ToolBox.Options;
-using Xunit;
 
 namespace ZeidLab.ToolBox.Test.Units.Options;
 

ToolBox.Test.Units/Options/MaybeExtensionsTapTests.cs

@@ -7,7 +7,7 @@ namespace ZeidLab.ToolBox.Test.Units.Options;
 
 public sealed class MaybeExtensionsTapTests
 {
-    #region TapIfSome
+    #region TapIfSome<TIn>(this Maybe<TIn> self, Action<TIn> action)
 
     [Fact]
     public void TapIfSome_Some_ActionIsExecuted()
@@ -39,10 +39,51 @@ public void TapIfSome_None_ActionIsNotExecuted()
         result.Should().Be(maybe);
     }
 
+    #endregion
+
+    #region TapIfSomeAsync<TIn>(this Maybe<TIn> self, Func<TIn,Task> action)
+
+    [Fact]
+    public async Task TapIfSomeAsync_InstanceSome_ActionIsExecuted()
+    {
+        // Arrange
+        var maybe = Maybe.Some(10);
+        var actionExecuted = false;
+
+        // Act
+        var result = await maybe.TapIfSomeAsync(async value =>
+        {
+            await Task.Delay(1);
+            actionExecuted = true;
+        });
+
+        // Assert
+        actionExecuted.Should().BeTrue();
+        result.Should().Be(maybe);
+    }
+
+    [Fact]
+    public async Task TapIfSomeAsync_InstanceNone_ActionIsNotExecuted()
+    {
+        // Arrange
+        var maybe = Maybe.None<int>();
+        var actionExecuted = false;
+
+        // Act
+        var result = await maybe.TapIfSomeAsync(async value =>
+        {
+            await Task.Delay(1);
+            actionExecuted = true;
+        });
+
+        // Assert
+        actionExecuted.Should().BeFalse();
+        result.Should().Be(maybe);
+    }
 
     #endregion
 
-    #region TapIfNone
+    #region TapIfNone<TIn>(this Maybe<TIn> self, Action action)
 
     [Fact]
     public void TapIfNone_None_ActionIsExecuted()
@@ -74,11 +115,51 @@ public void TapIfNone_Some_ActionIsNotExecuted()
         result.Should().Be(maybe);
     }
 
+    #endregion
+
+    #region TapIfNoneAsync<TIn>(this Maybe<TIn> self, Func<Task> action)
+
+    [Fact]
+    public async Task TapIfNoneAsync_InstanceNone_ActionIsExecuted()
+    {
+        // Arrange
+        var maybe = Maybe.None<int>();
+        var actionExecuted = false;
+
+        // Act
+        var result = await maybe.TapIfNoneAsync(async () =>
+        {
+            await Task.Delay(1);
+            actionExecuted = true;
+        });
+
+        // Assert
+        actionExecuted.Should().BeTrue();
+        result.Should().Be(maybe);
+    }
+
+    [Fact]
+    public async Task TapIfNoneAsync_InstanceSome_ActionIsNotExecuted()
+    {
+        // Arrange
+        var maybe = Maybe.Some(10);
+        var actionExecuted = false;
+
+        // Act
+        var result = await maybe.TapIfNoneAsync(async () =>
+        {
+            await Task.Delay(1);
+            actionExecuted = true;
+        });
 
+        // Assert
+        actionExecuted.Should().BeFalse();
+        result.Should().Be(maybe);
+    }
 
     #endregion
 
-    #region TapIfSomeAsync
+    #region TapIfSomeAsync<TIn>(this Task<Maybe<TIn>> self, Func<TIn, Task> action)
 
     [Fact]
     public async Task TapIfSomeAsync_Some_ActionIsExecuted()
@@ -110,10 +191,9 @@ public async Task TapIfSomeAsync_None_ActionIsNotExecuted()
         result.Should().Be(await maybeTask);
     }
 
-
     #endregion
 
-    #region TapIfNoneAsync
+    #region TapIfNoneAsync<TIn>(this Task<Maybe<TIn>> self, Func<Task> action)
 
     [Fact]
     public async Task TapIfNoneAsync_None_ActionIsExecuted()
@@ -145,7 +225,5 @@ public async Task TapIfNoneAsync_Some_ActionIsNotExecuted()
         result.Should().Be(await maybeTask);
     }
 
-
     #endregion
-
 }

ToolBox.Test.Units/Options/MaybeExtensionsTests.cs

@@ -1,8 +1,6 @@
 using System.Diagnostics.CodeAnalysis;
 using FluentAssertions;
-using NSubstitute;
 using ZeidLab.ToolBox.Options;
-using ZeidLab.ToolBox.Results;
 
 namespace ZeidLab.ToolBox.Test.Units.Options;
 

ToolBox.Test.Units/Results/ResultExtensionsEnsureTests.cs

@@ -1,9 +1,5 @@
-using System;
-using System.Threading.Tasks;
-using FluentAssertions;
-using Xunit;
+using FluentAssertions;
 using ZeidLab.ToolBox.Results;
-using ZeidLab.ToolBox.Test.Units.Common;
 
 namespace ZeidLab.ToolBox.Test.Units.Results;