Skip to content

Diagram title input has no Escape-to-revert #826

@MrCoder

Description

@MrCoder

Surfaced by the e2e gap suite (HDR-2, test.fixme in e2e/tests/header.spec.js).

Gap: the header title is a controlled <input> bound to setTitle on every keystroke (AppHeader.tsxeditorStore.setTitle); there is no draft buffer and no Escape/onKeyDown handler, so pressing Escape after editing does not revert. Common editors revert on Escape.

Fix: add a draft buffer + Escape-revert (and Enter-commit) to the title input. Then flip HDR-2 test.fixmetest.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions