Coverage fixes#1257
Merged
Merged
Conversation
nkemnitz
force-pushed
the
nkem/semi_lazy_import_cov
branch
from
456373a to
af6d4ce
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dodam/semi_lazy_import #1257 +/- ##
===========================================================
+ Coverage 99.62% 100.00% +0.37%
===========================================================
Files 211 211
Lines 11295 11292 -3
===========================================================
+ Hits 11253 11292 +39
+ Misses 42 0 -42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task management is unrelated to your change
But the other new coverage issues arose because the lazy imports now also cause our tests to skip many imports...