Merge pull request #7 from Zipstack/fix/schema-public-restriction

fix: allow public schema in model config and add warning in connection form

Author: wicky-zipstack

backend/visitran/adapters/postgres/connection.py

@@ -115,7 +115,7 @@ def list_all_schemas(self) -> list[str]:
         query = """
             SELECT nspname
             FROM pg_catalog.pg_namespace
-            WHERE nspname NOT IN ('information_schema', 'pg_catalog', 'public')
+            WHERE nspname NOT IN ('information_schema', 'pg_catalog')
                   AND nspname NOT LIKE 'pg_toast%'
                   AND nspname NOT LIKE 'pg_temp_%'
             ORDER BY nspname;

backend/visitran/adapters/postgres/schema.json

@@ -48,7 +48,7 @@
     "schema": {
       "type": "string",
       "title": "Schema",
-      "description": "default schema that visitran will build objects in"
+      "description": "Using 'public' is not recommended, consider a dedicated schema (e.g. 'analytics')."
     }
   },
   "required": ["host", "user", "passw", "dbname", "connection_url", "connection_type"]

backend/visitran/adapters/snowflake/connection.py

@@ -129,7 +129,7 @@ def list_all_schemas(self) -> list[str]:
             SELECT 
                 schema_name
             FROM information_schema.schemata
-            WHERE schema_name NOT IN ('INFORMATION_SCHEMA', 'PUBLIC')
+            WHERE schema_name NOT IN ('INFORMATION_SCHEMA')
             ORDER BY schema_name
         """
         rows = self.connection.raw_sql(sql_query).fetchall()

backend/visitran/adapters/snowflake/schema.json

@@ -48,7 +48,7 @@
     "schema": {
       "type": "string",
       "title": "Schema",
-      "description": "Schema",
+      "description": "Using 'public' is not recommended, consider a dedicated schema (e.g. 'analytics').",
       "minLength": 1
     },
     "role": {