[FreeBSD][1.38] Excess files in staging directory

[abishai]

Describe Your Environment

• Version of ZoneMinder 1.38.0
• How you installed ZoneMinder: from-source
• FreeBSD 14.3

Describe the bug
I'm porting 1.38.0 Zoneminder to FreeBSD and noticed excess files in staging directory. It looks like some dependencies are putting garbage files after build.

-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/cmake/jwt-cpp-targets.cmake
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/include/jwt-cpp
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/include/jwt-cpp/base.h
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/include/jwt-cpp/jwt.h
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/include/jwt-cpp/traits
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/include/jwt-cpp/traits/kazuho-picojson
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/include/jwt-cpp/traits/kazuho-picojson/traits.h
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/include/jwt-cpp/traits/kazuho-picojson/defaults.h
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/include/jwt-cpp/traits/boost-json
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/include/jwt-cpp/traits/boost-json/traits.h
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/include/jwt-cpp/traits/boost-json/defaults.h
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/include/jwt-cpp/traits/danielaparker-jsoncons
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/include/jwt-cpp/traits/danielaparker-jsoncons/traits.h
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/include/jwt-cpp/traits/danielaparker-jsoncons/defaults.h
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/include/jwt-cpp/traits/nlohmann-json
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/include/jwt-cpp/traits/nlohmann-json/traits.h
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/include/jwt-cpp/traits/nlohmann-json/defaults.h
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/include/jwt-cpp/traits/defaults.h.mustache
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/include/picojson/picojson.h
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/cmake/jwt-cpp-config.cmake
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/cmake/jwt-cpp-config-version.cmake
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/lib/libCxxUrl.a
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/include/CxxUrl/url.hpp
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/include/CxxUrl/string.hpp
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/lib/cmake/CxxUrl/CxxUrlTargets.cmake
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/lib/cmake/CxxUrl/CxxUrlTargets-release.cmake
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/lib/cmake/CxxUrl/CxxUrlConfigVersion.cmake
-- Up-to-date: /wrkdirs/usr/ports/multimedia/zoneminder/work-php84/stage/usr/local/lib/cmake/CxxUrl/CxxUrlConfig.cmake

I can remove them in post-install script, however, I think it is worth to remove them in build script, because this is affecting all packagers. For example, https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=zoneminder-git#n120

If you say this is normal, I'm totally fine, but 1.36 put nothing extra, so maybe it is a regression

[abishai]

I think, I'll unbundle dependencies and provide them separate as build deps. More lengthy way, but practically correct as no excess files will be put in stage area.

[connortechnology]

I think that is the way to go honestly.

[abishai]

It was trickier than I thought. There are 3 files that need to be changed to replace bundled dependency with external one. What do you think about knobs that can turn on or off specific external dependency?

For example,

option(USE_BUILTIN_JWTCPP "Use bundled JWT-CPP" YES)

If it is set to true, we include jwt-cpp from deps, if not - we try to find header files in include directory. (Not figured out how to do it properly yet).

We need it at least for JWT-CPP and Cxx-Url, because they install header files.

[connortechnology]

I find that AI is actually not bad at this. Can give it a try. I didn't both initially because no distro packages these things. But it is the correct way to go I think.

[connortechnology]

CxxUrl I think a little different in that it isn't header-only... but still same logic applies

[connortechnology]

Checkout #4596 and let me know if it solves the problem

[abishai]

I've got the following error using the packaged jwt-cpp

wrkdirs/usr/ports/multimedia/zoneminder/work-php84/zoneminder-1.38.0/src/zm_crypt.cpp:83:20: error: no matching function for call to 'decode'
   83 |     auto decoded = jwt::decode(jwt_token_str);
      |                    ^~~~~~~~~~~
/usr/local/include/jwt-cpp/jwt.h:3626:27: note: candidate template ignored: couldn't infer template argument 'json_traits'
 3626 |         decoded_jwt<json_traits> decode(const typename json_traits::string_type& token) {
      |                                  ^
/usr/local/include/jwt-cpp/jwt.h:3614:27: note: candidate function template not viable: requires 2 arguments, but 1 was provided
 3614 |         decoded_jwt<json_traits> decode(const typename json_traits::string_type& token, Decode decode) {
      |                                  ^      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/wrkdirs/usr/ports/multimedia/zoneminder/work-php84/zoneminder-1.38.0/src/zm_crypt.cpp:84:21: error: no matching function for call to 'verify'
   84 |     auto verifier = jwt::verify()
      |                     ^~~~~~~~~~~
/usr/local/include/jwt-cpp/jwt.h:3593:39: note: candidate template ignored: couldn't infer template argument 'json_traits'
 3593 |         verifier<default_clock, json_traits> verify(default_clock c = {}) {
      |                                              ^
/usr/local/include/jwt-cpp/jwt.h:3576:31: note: candidate function template not viable: requires single argument 'c', but no arguments were provided
 3576 |         verifier<Clock, json_traits> verify(Clock c) {
      |                                      ^      ~~~~~~~
2 errors generated.
*** [src/CMakeFiles/zm.dir/zm_crypt.cpp.o] Error code 1

Packaged version is slightly newer than bundled, but should be compatible

root@workshop-workshop:/usr/ports/multimedia/zoneminder # pkg list jwt-cpp
/usr/local/include/jwt-cpp/base.h
/usr/local/include/jwt-cpp/jwt.h
/usr/local/include/jwt-cpp/traits/boost-json/defaults.h
/usr/local/include/jwt-cpp/traits/boost-json/traits.h
/usr/local/include/jwt-cpp/traits/danielaparker-jsoncons/defaults.h
/usr/local/include/jwt-cpp/traits/danielaparker-jsoncons/traits.h
/usr/local/include/jwt-cpp/traits/defaults.h.mustache
/usr/local/include/jwt-cpp/traits/kazuho-picojson/defaults.h
/usr/local/include/jwt-cpp/traits/kazuho-picojson/traits.h
/usr/local/include/jwt-cpp/traits/nlohmann-json/defaults.h
/usr/local/include/jwt-cpp/traits/nlohmann-json/traits.h
/usr/local/include/jwt-cpp/traits/open-source-parsers-jsoncpp/defaults.h
/usr/local/include/jwt-cpp/traits/open-source-parsers-jsoncpp/traits.h
/usr/local/lib/cmake/jwt-cpp/jwt-cpp-config-version.cmake
/usr/local/lib/cmake/jwt-cpp/jwt-cpp-config.cmake
/usr/local/lib/cmake/jwt-cpp/jwt-cpp-targets.cmake
/usr/local/share/licenses/jwt-cpp-0.7.1_2/LICENSE
/usr/local/share/licenses/jwt-cpp-0.7.1_2/MIT
/usr/local/share/licenses/jwt-cpp-0.7.1_2/catalog.mk

I've tried to figure out what's happening and noticed that

1. include <jwt-cpp/jwt.h> works
2. jwt.h parsed
3. base.h included in jwt.h is parsed too
4. Error is the same if I mangle jwt namespace and change in to non existent.
5. Error is the same if I replace jwt.h and base.h from bundle (to check if public api is still compatible)
6. Well, I see compatible jwt::decode() in jwt.h with my own eyes.
7. jk, but there is another project, named cpp-jwt, so I've cheched I installed the right one ><

So, it looks like if includes works, but namespace is not there. Do you have any hints what can be wrong ? jwt-cpp is referenced in src/CMakeLists.txt. Maybe something there?